Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setting 'disable_place' #2154

Merged
merged 2 commits into from
Jan 18, 2024
Merged

add setting 'disable_place' #2154

merged 2 commits into from
Jan 18, 2024

Conversation

ArtificialOwl
Copy link
Member

No description provided.

@ArtificialOwl ArtificialOwl force-pushed the enh/noid/disable-place-setting branch from 65237e6 to 0047fa3 Compare November 24, 2023 08:36
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it plural? placeS

@ArtificialOwl ArtificialOwl force-pushed the enh/noid/disable-place-setting branch from 0047fa3 to 051e628 Compare November 24, 2023 12:51
@artonge
Copy link
Collaborator

artonge commented Nov 27, 2023

Same with method name and such

@ArtificialOwl ArtificialOwl force-pushed the enh/noid/disable-place-setting branch from 051e628 to 7f5ba86 Compare January 18, 2024 10:39
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/disable-place-setting branch from 7f5ba86 to da806b3 Compare January 18, 2024 15:49
@ArtificialOwl
Copy link
Member Author

@artonge please re-review and merge if fine

Use plural in exception

Signed-off-by: Louis <louis@chmn.me>
@artonge artonge enabled auto-merge January 18, 2024 16:18
@artonge artonge merged commit 240184d into master Jan 18, 2024
29 checks passed
@artonge artonge deleted the enh/noid/disable-place-setting branch January 18, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants