-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OCC comand add-photo-to-album #2172
Conversation
Not sure what you'd like for the UI. It seems like a couple of commands would be useful from OCC. Right now there's creating an album and adding pictures to it. This covers my main scripting use-cases, but if more features should be exposed to to occ, perhaps it makes sense to define if you'd like them in a single command file vs the multiple I have done here. |
The title is also misleading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, didn't see the other file, the title is not so misleading :)
I think I've addressed the comments and it's looking alright now. |
Some CI steps are failing. For
And then commit. For DCO, can you run:
And then push. |
3920e0a
to
207473e
Compare
Thanks for the instruction, I've never worked in a php environment before. |
You might have changed too many commits when running the DCO command :/ |
f127386
to
7b9c80e
Compare
Indeed! Alright, Nth time's the charm! DCO seems happy now, so I think this might be getting close. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect 👍
Signed-off-by: Christian McHugh <mchugh19@hotmail.com>
Signed-off-by: Christian McHugh <mchugh19@hotmail.com>
Signed-off-by: Christian McHugh <mchugh19@hotmail.com>
Co-authored-by: Louis <louis@chmn.me> Signed-off-by: Christian McHugh <mchugh19@hotmail.com>
Signed-off-by: Christian McHugh <mchugh19@hotmail.com>
Signed-off-by: Christian McHugh <mchugh19@hotmail.com>
Signed-off-by: Christian McHugh <mchugh19@hotmail.com>
Signed-off-by: Christian McHugh <mchugh19@hotmail.com>
e388b70
to
3e2cb7a
Compare
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Hey, for anyone stumbled upon this - I made a bash script for adding a whole folder to an album.
|
Creates a simple CLI for creating an album and adding a photo file to an album.