Fix checkbox layout #2182
Merged
Fix checkbox layout #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
bug
artonge
requested review from
a team,
szaimen,
sorbaugh and
emoral435
and removed request for
a team
backportbot-nextcloud
bot
added
the
backport-request
|
/compile / |
artonge
requested review from
susnux and
JuliaKirschenheuter
and removed request for
szaimen and
sorbaugh
artonge
force-pushed
the
artonge/fix/checkbox_layout
branch
from
ae15b5c to
b4f66aa
Compare
|
Why not dropping the So instead add the label as aria label here: photos/src/components/File.vue Line 74 in b4f66aa |
artonge
force-pushed
the
artonge/fix/checkbox_layout
branch
from
b4f66aa to
e1f4008
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/checkbox_layout
branch
from
e1f4008 to
5f6725a
Compare
emoral435
reviewed
Dec 7, 2023
| @@ -335,14 +334,14 @@ export default { | |||
| width: fit-content; | |||
|
|
|||
| // Make the checkbox background round on hover. | |||
There was a problem hiding this comment.
Right here, a nitpick is that now we want the background to always be present for accessibility reasons, no? So the comment could remove the hover part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue due to an internal change in
@nc/vue