Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor connectivity handling #2109

Closed
wants to merge 1 commit into from
Closed

Refactor connectivity handling #2109

wants to merge 1 commit into from

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 25, 2022 •
edited
Loading

  • Refactor connectivity handling

    • If requests to the Collabora server fail on the backend we mark the connectivity as failed but keep the cached responses, as in most cases this is a temporary issue. This also allows for more sane error reporting to the user in the future.
    • only perform heavy checks in the background job or when saving

  • Improved error reporting for admins

    • Move setup check messages out of the large settings component
    • Show actual error messages in case connecting doesn't work
    • Check frontend reachability by fetching the Collabora domain from the browser
    • Validate setup also when loading the admin page

  • Add cypress test that configures a faulty server and opens a file

  • Add cypress test that configures a valid server, stops it and opens a file (if easily possible)

Follow up

  • Get status on initial state
  • On timeout manually check status through separate requests
  • Lazy setup for richdocumentscode
  • Make public wopi url configurable as it is currently overwrritten on save

@juliusknorr juliusknorr added the 2. developing Work in progress label Apr 6, 2022
@juliusknorr juliusknorr added the enhancement New feature or request label Aug 4, 2022
@juliusknorr

This comment was marked as outdated.

Sign in to view
@juliusknorr juliusknorr force-pushed the enh/setup-checks branch 2 times, most recently from da063e7 to 88e7d97 Compare May 29, 2023 21:55
@juliusknorr juliusknorr changed the title Add more helpful setup checks Refactor connectivity handling May 29, 2023
@cypress
Copy link

cypress bot commented May 29, 2023 •
edited
Loading

1 failed test on run #590 ↗︎

1 26 5 0 Flakiness 0

Details:

Refactor connectivity handling
Project: Richdocuments Commit: bad88c70f0
Status: Failed Duration: 02:40 💡
Started: Sep 8, 2023 10:19 PM Ended: Sep 8, 2023 10:21 PM
Failed  cypress/e2e/settings.spec.js • 1 failed test

View Output Video

Test Artifacts
Office admin settings > Error for invalid url Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr juliusknorr added 3. to review Ready to be reviewed technical debt and removed 2. developing Work in progress labels May 31, 2023
@juliusknorr juliusknorr added this to the Nextcloud 28 milestone May 31, 2023
@juliusknorr juliusknorr marked this pull request as ready for review May 31, 2023 09:34
@juliusknorr juliusknorr linked an issue Jun 29, 2023 that may be closed by this pull request
Improve setup checks #1835
Closed
@juliusknorr
Copy link
Member Author

Waiting to get #3152 in first

@juliusknorr
Add more helpful setup checks
709f5a9 
Signed-off-by: Julius Härtl <jus@bitgrid.net>

wip: tests

Signed-off-by: Julius Härtl <jus@bitgrid.net>

wip: clear

Signed-off-by: Julius Härtl <jus@bitgrid.net>

followup

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

Replacing this with #3315 as I needed some refactoring for URL handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luka-nextcloud luka-nextcloud luka-nextcloud approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Ready to be reviewed enhancement New feature or request technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Improve setup checks
2 participants
@juliusknorr @luka-nextcloud