feat: Check remove server connectivity #4361
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juliusknorr
commented
Dec 27, 2024
•
juliusknorr
commented
- Fetch remote endpoint to check connectivity
- Cover all status cases
- Make API call optional depending on availability of the new endpoint
- Properly expose error messages with hints in the settings
Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorr
added
enhancement
meven
reviewed
Dec 30, 2024
| ], | ||
| ]); | ||
| $result = json_decode($response->getBody(), true, 512, JSON_THROW_ON_ERROR); | ||
| if ($result['status'] === 'CheckStatus::WopiHostNotAllowed') { |
There was a problem hiding this comment.
Suggested change
| if ($result['status'] === 'CheckStatus::WopiHostNotAllowed') { | |
| if ($result['status'] === 'WopiHostNotAllowed') { |
I have simplified this to just be WopiHostNotAllowed in CollaboraOnline/online#10807
I am taking the time window until mid-january and next COOL stable version to make small API corrections before they are completely set in stone.
You can see the MR related at the end of CollaboraOnline/online#9202
meven
reviewed
Dec 30, 2024
| public function testCallback(OutputInterface $output): void { | ||
| $url = $this->parser->getUrlSrcValue('Capabilities'); | ||
| if ($url === '') { | ||
| // Fixme can we skip early if the collabora version does not have the wopiAccessCheck endpoint, maybe it can be exposed in discovery |
There was a problem hiding this comment.
That was suggested will probably add to discovery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.