Skip to content

IFilesMetadata

IFilesMetadata #33033

Triggered via pull request October 22, 2023 11:21
Status Failure
Total duration 8m 28s
Artifacts

static-code-analysis.yml

on: pull_request
static-code-analysis
3m 58s
static-code-analysis
static-code-analysis-security
8m 17s
static-code-analysis-security
static-code-analysis-ocp
2m 46s
static-code-analysis-ocp
Fit to window
Zoom out
Zoom in

Annotations

29 errors
InvalidDocblock: lib/public/FilesMetadata/Event/MetadataBackgroundEvent.php#L33
lib/public/FilesMetadata/Event/MetadataBackgroundEvent.php:33:1: InvalidDocblock: PHPDoc is required for classes/interfaces in OCP. (see https://psalm.dev/008)
InvalidDocblock: lib/public/FilesMetadata/Event/MetadataBackgroundEvent.php#L34
lib/public/FilesMetadata/Event/MetadataBackgroundEvent.php:34:2: InvalidDocblock: PHPDoc is required for methods in OCP. (see https://psalm.dev/008)
InvalidDocblock: lib/public/FilesMetadata/Event/MetadataLiveEvent.php#L33
lib/public/FilesMetadata/Event/MetadataLiveEvent.php:33:1: InvalidDocblock: PHPDoc is required for classes/interfaces in OCP. (see https://psalm.dev/008)
InvalidDocblock: lib/public/FilesMetadata/Event/MetadataLiveEvent.php#L36
lib/public/FilesMetadata/Event/MetadataLiveEvent.php:36:2: InvalidDocblock: PHPDoc is required for methods in OCP. (see https://psalm.dev/008)
InvalidDocblock: lib/public/FilesMetadata/Exceptions/FilesMetadataException.php#L9
lib/public/FilesMetadata/Exceptions/FilesMetadataException.php:9:1: InvalidDocblock: PHPDoc is required for classes/interfaces in OCP. (see https://psalm.dev/008)
InvalidDocblock: lib/public/FilesMetadata/Exceptions/FilesMetadataNotFoundException.php#L7
lib/public/FilesMetadata/Exceptions/FilesMetadataNotFoundException.php:7:1: InvalidDocblock: PHPDoc is required for classes/interfaces in OCP. (see https://psalm.dev/008)
InvalidDocblock: lib/public/FilesMetadata/Exceptions/FilesMetadataTypeException.php#L7
lib/public/FilesMetadata/Exceptions/FilesMetadataTypeException.php:7:1: InvalidDocblock: PHPDoc is required for classes/interfaces in OCP. (see https://psalm.dev/008)
InvalidDocblock: lib/public/FilesMetadata/IFilesMetadataManager.php#L12
lib/public/FilesMetadata/IFilesMetadataManager.php:12:1: InvalidDocblock: PHPDoc is required for classes/interfaces in OCP. (see https://psalm.dev/008)
InvalidDocblock: lib/public/FilesMetadata/IFilesMetadataManager.php#L16
lib/public/FilesMetadata/IFilesMetadataManager.php:16:2: InvalidDocblock: PHPDoc is required for methods in OCP. (see https://psalm.dev/008)
InvalidDocblock: lib/public/FilesMetadata/IFilesMetadataManager.php#L22
lib/public/FilesMetadata/IFilesMetadataManager.php:22:2: InvalidDocblock: PHPDoc is required for methods in OCP. (see https://psalm.dev/008)
MoreSpecificReturnType: lib/private/Files/Cache/QuerySearchHelper.php#L133
lib/private/Files/Cache/QuerySearchHelper.php:133:97: MoreSpecificReturnType: The declared return type 'OC\FilesMetadata\Model\MetadataQuery|null' for OC\Files\Cache\QuerySearchHelper::equipQueryForMetadata is more specific than the inferred return type 'OCP\FilesMetadata\Model\IMetadataQuery' (see https://psalm.dev/070)
LessSpecificReturnStatement: lib/private/Files/Cache/QuerySearchHelper.php#L146
lib/private/Files/Cache/QuerySearchHelper.php:146:10: LessSpecificReturnStatement: The type 'OCP\FilesMetadata\Model\IMetadataQuery' is more general than the declared return type 'OC\FilesMetadata\Model\MetadataQuery|null' for OC\Files\Cache\QuerySearchHelper::equipQueryForMetadata (see https://psalm.dev/129)
MissingTemplateParam: lib/private/FilesMetadata/Listener/MetadataDelete.php#L38
lib/private/FilesMetadata/Listener/MetadataDelete.php:38:33: MissingTemplateParam: OC\FilesMetadata\Listener\MetadataDelete has missing template params when extending OCP\EventDispatcher\IEventListener, expecting 1 (see https://psalm.dev/182)
MissingTemplateParam: lib/private/FilesMetadata/Listener/MetadataUpdate.php#L41
lib/private/FilesMetadata/Listener/MetadataUpdate.php:41:33: MissingTemplateParam: OC\FilesMetadata\Listener\MetadataUpdate has missing template params when extending OCP\EventDispatcher\IEventListener, expecting 1 (see https://psalm.dev/182)
ParamNameMismatch: lib/private/FilesMetadata/Model/FilesMetadata.php#L299
lib/private/FilesMetadata/Model/FilesMetadata.php:299:51: ParamNameMismatch: Argument 2 of OC\FilesMetadata\Model\FilesMetadata::setStringList has wrong name $values, expecting $value as defined by OCP\FilesMetadata\Model\IFilesMetadata::setStringList (see https://psalm.dev/230)
ParamNameMismatch: lib/private/FilesMetadata/Model/FilesMetadata.php#L307
lib/private/FilesMetadata/Model/FilesMetadata.php:307:48: ParamNameMismatch: Argument 2 of OC\FilesMetadata\Model\FilesMetadata::setIntList has wrong name $values, expecting $value as defined by OCP\FilesMetadata\Model\IFilesMetadata::setIntList (see https://psalm.dev/230)
ImplicitToStringCast: lib/private/FilesMetadata/Service/MetadataRequestService.php#L37
lib/private/FilesMetadata/Service/MetadataRequestService.php:37:32: ImplicitToStringCast: Argument 2 of OCP\DB\QueryBuilder\IQueryBuilder::setValue expects OCP\DB\QueryBuilder\IParameter|string, but OCP\DB\QueryBuilder\IQueryFunction provided with a __toString method (see https://psalm.dev/060)
MismatchingDocblockReturnType: lib/private/FilesMetadata/Service/MetadataRequestService.php#L90
lib/private/FilesMetadata/Service/MetadataRequestService.php:90:13: MismatchingDocblockReturnType: Docblock has incorrect return type 'bool', should be 'int' (see https://psalm.dev/142)
static-code-analysis
Process completed with exit code 2.
TaintedHtml: apps/admin_audit/lib/Actions/Action.php#L62
apps/admin_audit/lib/Actions/Action.php:62:16: TaintedHtml: Detected tainted HTML (see https://psalm.dev/245)
TaintedCallable: apps/files_external/lib/Config/ConfigAdapter.php#L74
apps/files_external/lib/Config/ConfigAdapter.php:74:50: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
TaintedFile: apps/files_external/lib/Lib/Storage/SFTP.php#L247
apps/files_external/lib/Lib/Storage/SFTP.php:247:17: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
TaintedFile: apps/files_external/lib/Lib/Storage/SFTP.php#L268
apps/files_external/lib/Lib/Storage/SFTP.php:268:19: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
TaintedFile: apps/files_external/lib/Lib/Storage/SFTP.php#L413
apps/files_external/lib/Lib/Storage/SFTP.php:413:22: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
TaintedCookie: apps/files_sharing/lib/Controller/ShareController.php#L463
apps/files_sharing/lib/Controller/ShareController.php:463:35: TaintedCookie: Detected tainted cookie (see https://psalm.dev/257)
TaintedFile: apps/theming/lib/IconBuilder.php#L137
apps/theming/lib/IconBuilder.php:137:40: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
TaintedFile: apps/theming/lib/IconBuilder.php#L235
apps/theming/lib/IconBuilder.php:235:28: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
TaintedHeader: lib/base.php#L204
lib/base.php:204:12: TaintedHeader: Detected tainted header (see https://psalm.dev/256)
TaintedHeader: lib/base.php#L286
lib/base.php:286:12: TaintedHeader: Detected tainted header (see https://psalm.dev/256)