chore(systemtags): pre-compute user authorizations

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
nextcloud · Dec 3, 2024 · 0026817 · 0026817
1 parent b638dd1
commit 0026817
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/apps/dav/lib/SystemTag/SystemTagList.php b/apps/dav/lib/SystemTag/SystemTagList.php
@@ -19,18 +19,20 @@
  */
 class SystemTagList implements Element {
 	public const NS_NEXTCLOUD = 'http://nextcloud.org/ns';
+	private array $canAssignTagMap = [];
 
 	/**
 	 * @param ISystemTag[] $tags
 	 */
 	public function __construct(
 		private array $tags,
-		private ISystemTagManager $tagManager,
-		private ?IUser $user,
+		ISystemTagManager $tagManager,
+		?IUser $user,
 	) {
 		$this->tags = $tags;
-		$this->tagManager = $tagManager;
-		$this->user = $user;
+		foreach ($this->tags as $tag) {
+			$this->canAssignTagMap[$tag->getId()] = $tagManager->canUserAssignTag($tag, $user);
+		}
 	}
 
 	/**
@@ -48,7 +50,7 @@ public function xmlSerialize(Writer $writer): void {
 		foreach ($this->tags as $tag) {
 			$writer->startElement('{' . self::NS_NEXTCLOUD . '}system-tag');
 			$writer->writeAttributes([
-				SystemTagPlugin::CANASSIGN_PROPERTYNAME => $this->tagManager->canUserAssignTag($tag, $this->user) ? 'true' : 'false',
+				SystemTagPlugin::CANASSIGN_PROPERTYNAME => $this->canAssignTagMap[$tag->getId()] ? 'true' : 'false',
 				SystemTagPlugin::ID_PROPERTYNAME => $tag->getId(),
 				SystemTagPlugin::USERASSIGNABLE_PROPERTYNAME => $tag->isUserAssignable() ? 'true' : 'false',
 				SystemTagPlugin::USERVISIBLE_PROPERTYNAME => $tag->isUserVisible() ? 'true' : 'false',