Skip to content

Commit

Permalink
Clear generated avatar caches
Browse files Browse the repository at this point in the history
Signed-off-by: jld3103 <jld3103yt@gmail.com>
  • Loading branch information
provokateurin committed May 15, 2023
1 parent 9c35bdf commit 1bc3572
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions lib/private/Repair/ClearGeneratedAvatarCache.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function __construct(IConfig $config, AvatarManager $avatarManager, IJobL
}

public function getName(): string {
return 'Clear every generated avatar on major updates';
return 'Clear every generated avatar';
}

/**
Expand All @@ -51,8 +51,9 @@ public function getName(): string {
private function shouldRun(): bool {
$versionFromBeforeUpdate = $this->config->getSystemValueString('version', '0.0.0.0');

// was added to 25.0.0.10
return version_compare($versionFromBeforeUpdate, '25.0.0.10', '<=');
// This job only runs if the server was on a version lower than or equal to 27.0.0 before the upgrade.
// To clear the avatar cache again, bump the version to the currently released version (and change the operator to <= if it's not the master branch) and wait for the next release.
return version_compare($versionFromBeforeUpdate, '27.0.0', '<');
}

public function run(IOutput $output): void {
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/Repair/ClearGeneratedAvatarCacheTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function shouldRunDataProvider() {
['15.0.0.3', true],
['13.0.5.2', true],
['12.0.0.0', true],
['26.0.0.1', false],
['26.0.0.1', true],
['15.0.0.2', true],
['13.0.0.0', true],
['27.0.0.5', false]
Expand Down

0 comments on commit 1bc3572

Please sign in to comment.