Fix occ integrity:check-app and Admin panel "rescan" deliver incons…

…istent results Signed-off-by: Seungmin Kim <8457324+ehfd@users.noreply.github.com>
nextcloud · Dec 1, 2024 · 2a1ae91 · 2a1ae91
1 parent e17f011
commit 2a1ae91
Showing 1 changed file with 16 additions and 7 deletions.
diff --git a/core/Command/Integrity/CheckApp.php b/core/Command/Integrity/CheckApp.php
@@ -9,6 +9,8 @@
 
 use OC\Core\Command\Base;
 use OC\IntegrityCheck\Checker;
+use OC\IntegrityCheck\Helpers\AppLocator;
+use OC\IntegrityCheck\Helpers\FileAccessHelper;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -22,6 +24,8 @@
 class CheckApp extends Base {
 	public function __construct(
 		private Checker $checker,
+		private AppLocator $appLocator,
+		private FileAccessHelper $fileAccessHelper,
 	) {
 		parent::__construct();
 	}
@@ -43,14 +47,19 @@ protected function configure() {
 	 */
 	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$appid = $input->getArgument('appid');
-		$path = (string)$input->getOption('path');
-		$result = $this->checker->verifyAppSignature($appid, $path, true);
-		$this->writeArrayInOutputFormat($input, $output, $result);
-		if (count($result) > 0) {
-			$output->writeln('<error>' . count($result) . ' errors found</error>', OutputInterface::VERBOSITY_VERBOSE);
-			return 1;
+		$path = (string)$input->getOption('path') ?? $this->appLocator->getAppPath($appid);
+		if ($this->fileAccessHelper->file_exists($path . '/appinfo/signature.json')) {
+			// Only verify if the application explicitly ships a signature.json file
+			$result = $this->checker->verifyAppSignature($appid, $path, true);
+			$this->writeArrayInOutputFormat($input, $output, $result);
+			if (count($result) > 0) {
+				$output->writeln('<error>' . count($result) . ' errors found</error>', OutputInterface::VERBOSITY_VERBOSE);
+				return 1;
+			}
+			$output->writeln('<info>No errors found</info>', OutputInterface::VERBOSITY_VERBOSE);
+		} else {
+			$output->writeln('<info>App signature not found, skipping app integrity check</info>', OutputInterface::VERBOSITY_VERBOSE);
 		}
-		$output->writeln('<info>No errors found</info>', OutputInterface::VERBOSITY_VERBOSE);
 		return 0;
 	}
 }