Skip to content

Commit

Permalink
fix(files): Remove confusing table header labels
Browse files Browse the repository at this point in the history
For screen readers the table header was very verbose and confusing,
as the SR reads out e.g. "sort list by name button FILENAME" for every row / file.
Instead reduce it to "name button FILENAME" and add information about sorting to caption, as recommended by WCAG [1]

[1]: https://www.w3.org/WAI/ARIA/apg/patterns/table/examples/sortable-table/

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
  • Loading branch information
susnux committed Dec 1, 2023
1 parent 7f4be00 commit 32d356d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
8 changes: 0 additions & 8 deletions apps/files/src/components/FilesListTableHeaderButton.vue
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
'files-list__column-sort-button--active': sortingMode === mode,
'files-list__column-sort-button--size': sortingMode === 'size',
}]"
:aria-label="sortAriaLabel"
:alignment="mode === 'size' ? 'end' : 'start-reverse'"
type="tertiary"
@click="toggleSortBy(mode)">
Expand Down Expand Up @@ -71,13 +70,6 @@ export default defineComponent({
},
},

computed: {
sortAriaLabel() {
return this.t('files', 'Sort list by {column}', {
column: this.name,
})
},
},
methods: {
t: translate,
},
Expand Down
3 changes: 2 additions & 1 deletion apps/files/src/components/FilesListVirtual.vue
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,9 @@ export default defineComponent({
caption() {
const defaultCaption = t('files', 'List of files and folders.')
const viewCaption = this.currentView.caption || defaultCaption
const sortableCaption = t('files', 'Column headers with buttons are sortable.')
const virtualListNote = t('files', 'This list is not fully rendered for performance reasons. The files will be rendered as you navigate through the list.')
return viewCaption + '\n' + virtualListNote
return `${viewCaption}\n${sortableCaption}\n${virtualListNote}`
},
},

Expand Down

0 comments on commit 32d356d

Please sign in to comment.