Skip to content

Commit

Permalink
fix(files): correct item height
Browse files Browse the repository at this point in the history
1. grid: typo? The icon size is 160 - 44 + (44 / 2) = 138px
2. non-grid: border is already included in height because the tr
   is a border-box (made this explicit to be safe)

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
  • Loading branch information
pulsejet authored and susnux committed Oct 21, 2023
1 parent 114ee4c commit 52d8712
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions apps/files/src/components/FilesListVirtual.vue
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,7 @@ export default Vue.extend({
width: 100%;
user-select: none;
border-bottom: 1px solid var(--color-border);
box-sizing: border-box;
user-select: none;
height: var(--row-height);
}
Expand Down
2 changes: 1 addition & 1 deletion apps/files/src/components/VirtualList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export default Vue.extend({
itemHeight() {
// Align with css in FilesListVirtual
// 138px + 44px (name) + 15px (grid gap)
return this.gridMode ? (160 + 44 + 15) : 56
return this.gridMode ? (138 + 44 + 15) : 55
},
// Grid mode only
itemWidth() {
Expand Down

0 comments on commit 52d8712

Please sign in to comment.