Skip to content

Commit

Permalink
Merge pull request #41035 from nextcloud/fix/37092/apps-list--html-va…
Browse files Browse the repository at this point in the history
…lidation

fix(settings): apps list html validation and loading icon
  • Loading branch information
susnux authored Oct 24, 2023
2 parents 7a55ea7 + 7e94468 commit 6753aaf
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 14 deletions.
12 changes: 8 additions & 4 deletions apps/settings/src/components/AppList/AppItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
class="app-icon" />
</svg>

<img v-if="!listView && app.screenshot && screenshotLoaded" :src="app.screenshot" width="100%">
<img v-if="!listView && app.screenshot && screenshotLoaded" :src="app.screenshot" alt="">
</component>
<component :is="dataItemTag"
class="app-name"
Expand Down Expand Up @@ -210,7 +210,11 @@ export default {
</script>

<style scoped lang="scss">
.app-icon {
filter: var(--background-invert-if-bright);
}
.app-icon {
filter: var(--background-invert-if-bright);
}

.app-image img {
width: 100%;
}
</style>
6 changes: 2 additions & 4 deletions apps/settings/src/views/Apps.vue
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,9 @@

<template>
<NcContent app-name="settings"
:class="{ 'with-app-sidebar': app}"
:content-class="{ 'icon-loading': loadingList }"
:navigation-class="{ 'icon-loading': loading }">
:class="{ 'with-app-sidebar': app}">
<!-- Categories & filters -->
<NcAppNavigation>
<NcAppNavigation :class="{ 'icon-loading': loading }">
<template #list>
<NcAppNavigationItem id="app-category-your-apps"
:to="{ name: 'apps' }"
Expand Down
4 changes: 2 additions & 2 deletions dist/settings-apps-view-7418.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-apps-view-7418.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/settings-vue-settings-apps-users-management.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-vue-settings-apps-users-management.js.map

Large diffs are not rendered by default.

0 comments on commit 6753aaf

Please sign in to comment.