Properly clear cached avatars

Signed-off-by: jld3103 <jld3103yt@gmail.com>
nextcloud · May 9, 2023 · 8ab71af · 8ab71af
1 parent 53957cf
commit 8ab71af
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/lib/private/Avatar/AvatarManager.php b/lib/private/Avatar/AvatarManager.php
@@ -160,13 +160,8 @@ public function getAvatar(string $userId) : IAvatar {
 	public function clearCachedAvatars() {
 		$users = $this->config->getUsersForUserValue('avatar', 'generated', 'true');
 		foreach ($users as $userId) {
-			try {
-				$folder = $this->appData->getFolder($userId);
-				$folder->delete();
-			} catch (NotFoundException $e) {
-				$this->logger->debug("No cache for the user $userId. Ignoring...");
-			}
-			$this->config->setUserValue($userId, 'avatar', 'generated', 'false');
+			// This also bumps the avatar version leading to cache invalidation in browsers
+			$this->getAvatar($userId)->remove();
 		}
 	}