Merge pull request #49839 from nextcloud/fix/issue-3021-return-no-con…

…tent-instead-of-error fix: return 204 instead of 404
nextcloud · Dec 13, 2024 · afc4b0a · afc4b0a
2 parents 10852d3 + 0628eb6
commit afc4b0a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/apps/dav/lib/CardDAV/ImageExportPlugin.php b/apps/dav/lib/CardDAV/ImageExportPlugin.php
@@ -90,7 +90,7 @@ public function httpGet(RequestInterface $request, ResponseInterface $response)
 
 			$response->setBody($file->getContent());
 		} catch (NotFoundException $e) {
-			$response->setStatus(404);
+			$response->setStatus(\OCP\AppFramework\Http::STATUS_NO_CONTENT);
 		}
 
 		return false;

diff --git a/apps/dav/tests/unit/CardDAV/ImageExportPluginTest.php b/apps/dav/tests/unit/CardDAV/ImageExportPluginTest.php
@@ -171,7 +171,7 @@ public function testCard($size, $photo): void {
 				->willThrowException(new NotFoundException());
 			$this->response->expects($this->once())
 				->method('setStatus')
-				->with(404);
+				->with(\OCP\AppFramework\Http::STATUS_NO_CONTENT);
 		}
 
 		$result = $this->plugin->httpGet($this->request, $this->response);