Explicitly close the directory stream

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Close the stream Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
nextcloud · Oct 20, 2023 · c61afb1 · c61afb1
1 parent e49353d
commit c61afb1
Show file tree

Hide file tree

Showing 11 changed files with 26 additions and 10 deletions.
diff --git a/apps/encryption/lib/Command/FixKeyLocation.php b/apps/encryption/lib/Command/FixKeyLocation.php
@@ -366,6 +366,7 @@ private function findKeysByFileName(string $basePath, string $name) {
 					}
 				}
 			}
+			closedir($dh);
 		}
 	}
 

diff --git a/apps/files_trashbin/lib/Trashbin.php b/apps/files_trashbin/lib/Trashbin.php
@@ -1119,6 +1119,7 @@ public static function isEmpty($user) {
 					return false;
 				}
 			}
+			closedir($dh);
 		}
 		return true;
 	}

diff --git a/lib/private/Archive/Archive.php b/lib/private/Archive/Archive.php
@@ -120,6 +120,7 @@ public function addRecursive(string $path, string $source): void {
 					$this->addFile($path.'/'.$file, $source.'/'.$file);
 				}
 			}
+			closedir($dh);
 		}
 	}
 }
diff --git a/lib/private/Cache/File.php b/lib/private/Cache/File.php
@@ -156,14 +156,15 @@ public function remove($key) {
 	 */
 	public function clear($prefix = '') {
 		$storage = $this->getStorage();
-		if ($storage and $storage->is_dir('/')) {
+		if ($storage && $storage->is_dir('/')) {
 			$dh = $storage->opendir('/');
 			if (is_resource($dh)) {
 				while (($file = readdir($dh)) !== false) {
-					if ($file != '.' and $file != '..' and ($prefix === '' || str_starts_with($file, $prefix))) {
+					if ($file != '.' && $file != '..' && ($prefix === '' || str_starts_with($file, $prefix))) {
 						$storage->unlink('/' . $file);
 					}
 				}
+				closedir($dh);
 			}
 		}
 		return true;
@@ -184,7 +185,7 @@ public function gc() {
 				return null;
 			}
 			while (($file = readdir($dh)) !== false) {
-				if ($file != '.' and $file != '..') {
+				if ($file != '.' && $file != '..') {
 					try {
 						$mtime = $storage->filemtime('/' . $file);
 						if ($mtime < $now) {
@@ -200,6 +201,7 @@ public function gc() {
 					}
 				}
 			}
+			closedir($dh);
 		}
 	}
 

diff --git a/lib/private/Files/Storage/Common.php b/lib/private/Files/Storage/Common.php
@@ -294,6 +294,7 @@ private function addLocalFolder($path, $target) {
 					}
 				}
 			}
+			closedir($dh);
 		}
 	}
 
@@ -317,8 +318,8 @@ protected function searchInDir($query, $dir = '') {
 					$files = array_merge($files, $this->searchInDir($query, $dir . '/' . $item));
 				}
 			}
+			closedir($dh);
 		}
-		closedir($dh);
 		return $files;
 	}
 
@@ -626,6 +627,7 @@ public function copyFromStorage(IStorage $sourceStorage, $sourceInternalPath, $t
 						$result &= $this->copyFromStorage($sourceStorage, $sourceInternalPath . '/' . $file, $targetInternalPath . '/' . $file);
 					}
 				}
+				closedir($dh);
 			}
 		} else {
 			$source = $sourceStorage->fopen($sourceInternalPath, 'r');
@@ -905,6 +907,7 @@ public function getDirectoryContent($directory): \Traversable {
 					}
 				}
 			}
+			closedir($dh);
 		}
 	}
 }
diff --git a/lib/private/Files/Storage/Wrapper/Encryption.php b/lib/private/Files/Storage/Wrapper/Encryption.php
@@ -824,11 +824,12 @@ private function copyBetweenStorage(
 				$result = true;
 			}
 			if (is_resource($dh)) {
-				while ($result and ($file = readdir($dh)) !== false) {
+				while ($result && ($file = readdir($dh)) !== false) {
 					if (!Filesystem::isIgnoredDir($file)) {
 						$result &= $this->copyFromStorage($sourceStorage, $sourceInternalPath . '/' . $file, $targetInternalPath . '/' . $file, false, $isRename);
 					}
 				}
+				closedir($dh);
 			}
 		} else {
 			try {

diff --git a/lib/private/TempManager.php b/lib/private/TempManager.php
@@ -189,7 +189,7 @@ protected function getOldFiles() {
 		$cutOfTime = time() - 3600;
 		$files = [];
 		$dh = opendir($this->tmpBaseDir);
-		if ($dh) {
+		if (is_resource($dh) {
 			while (($file = readdir($dh)) !== false) {
 				if (substr($file, 0, 7) === self::TMP_PREFIX) {
 					$path = $this->tmpBaseDir . '/' . $file;
@@ -199,6 +199,7 @@ protected function getOldFiles() {
 					}
 				}
 			}
+			closedir($dh);
 		}
 		return $files;
 	}

diff --git a/lib/private/legacy/OC_App.php b/lib/private/legacy/OC_App.php
@@ -523,10 +523,11 @@ public static function getAllApps(): array {
 
 			if (is_resource($dh)) {
 				while (($file = readdir($dh)) !== false) {
-					if ($file[0] != '.' and is_dir($apps_dir['path'] . '/' . $file) and is_file($apps_dir['path'] . '/' . $file . '/appinfo/info.xml')) {
+					if ($file[0] != '.' && is_dir($apps_dir['path'] . '/' . $file) && is_file($apps_dir['path'] . '/' . $file . '/appinfo/info.xml')) {
 						$apps[] = $file;
 					}
 				}
+				closedir($dh);
 			}
 		}
 

diff --git a/tests/apps.php b/tests/apps.php
@@ -31,6 +31,7 @@ function loadDirectory($path): void {
 			require_once $file;
 		}
 	}
+	closedir($dh);
 }
 
 function getSubclasses($parentClassName): array {

diff --git a/tests/lib/Files/Storage/Storage.php b/tests/lib/Files/Storage/Storage.php
@@ -82,10 +82,11 @@ public function testDirectories($directory) {
 		$dh = $this->instance->opendir('/');
 		$content = [];
 		while ($file = readdir($dh)) {
-			if ($file != '.' and $file != '..') {
+			if ($file != '.' && $file != '..') {
 				$content[] = $file;
 			}
 		}
+		closedir($dh);
 		$this->assertEquals([$directory], $content);
 
 		$content = iterator_to_array($this->instance->getDirectoryContent('/'));
@@ -114,10 +115,11 @@ public function testDirectories($directory) {
 		$dh = $this->instance->opendir('/');
 		$content = [];
 		while ($file = readdir($dh)) {
-			if ($file != '.' and $file != '..') {
+			if ($file != '.' && $file != '..') {
 				$content[] = $file;
 			}
 		}
+		closedir($dh);
 		$this->assertEquals([], $content);
 	}
 
@@ -455,10 +457,11 @@ public function testHashInFileName() {
 		$dh = $this->instance->opendir('#foo');
 		$content = [];
 		while ($file = readdir($dh)) {
-			if ($file != '.' and $file != '..') {
+			if ($file != '.' && $file != '..') {
 				$content[] = $file;
 			}
 		}
+		closedir($dh);
 
 		$this->assertEquals(['test.txt'], $content);
 	}

diff --git a/tests/lib/Files/Storage/Wrapper/JailTest.php b/tests/lib/Files/Storage/Wrapper/JailTest.php
@@ -33,6 +33,7 @@ protected function tearDown(): void {
 				$contents[] = $file;
 			}
 		}
+		closedir($dh);
 		$this->assertEquals(['foo'], $contents);
 		$this->sourceStorage->cleanUp();
 		parent::tearDown();
-Original file line number
+Diff line change
@@ Expand Up @@
     					}
     				}
     			}
+    			closedir($dh);
     		}
     	}
@@ Expand Down @@