fix(ShareApiController): Set hideDownload to inverse of allow downloa…

…d attribute

If the download attribute is set to false, then we should set hideDownload to
true (essentially hiding the download button from the UI) and vice versa

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

apps/files_sharing/lib/Controller/ShareAPIController.php

@@ -637,6 +637,10 @@ public function createShare(
 
 		if ($attributes !== null) {
 			$share = $this->setShareAttributes($share, $attributes);
+			if ($shareAttributes = $share->getAttributes()) {
+				$downloadPermission = (bool) $shareAttributes->getAttribute('permissions', 'download');
+				$share->setHideDownload(!$downloadPermission);
+			}
 		}
 
 		// Expire date