Merge pull request #41951 from nextcloud/fix/files-table-headers

fix(files): Remove confusing table header labels
nextcloud · Dec 1, 2023 · e915c7d · e915c7d
2 parents 2943304 + 57afeb1
commit e915c7d
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 12 deletions.
diff --git a/apps/files/src/components/FilesListTableHeaderButton.vue b/apps/files/src/components/FilesListTableHeaderButton.vue
@@ -25,7 +25,6 @@
 			'files-list__column-sort-button--active': sortingMode === mode,
 			'files-list__column-sort-button--size': sortingMode === 'size',
 		}]"
-		:aria-label="sortAriaLabel"
 		:alignment="mode === 'size' ? 'end' : 'start-reverse'"
 		type="tertiary"
 		@click="toggleSortBy(mode)">
@@ -71,13 +70,6 @@ export default defineComponent({
 		},
 	},
 
-	computed: {
-		sortAriaLabel() {
-			return this.t('files', 'Sort list by {column}', {
-				column: this.name,
-			})
-		},
-	},
 	methods: {
 		t: translate,
 	},

diff --git a/apps/files/src/components/FilesListVirtual.vue b/apps/files/src/components/FilesListVirtual.vue
@@ -182,8 +182,9 @@ export default defineComponent({
 		caption() {
 			const defaultCaption = t('files', 'List of files and folders.')
 			const viewCaption = this.currentView.caption || defaultCaption
+			const sortableCaption = t('files', 'Column headers with buttons are sortable.')
 			const virtualListNote = t('files', 'This list is not fully rendered for performance reasons. The files will be rendered as you navigate through the list.')
-			return viewCaption + '\n' + virtualListNote
+			return `${viewCaption}\n${sortableCaption}\n${virtualListNote}`
 		},
 	},
 

diff --git a/dist/files-main.js b/dist/files-main.js
diff --git a/dist/files-main.js.map b/dist/files-main.js.map