Missing things in database should be warning, not info

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
nextcloud · Nov 23, 2023 · f458add · f458add
1 parent 6c6436c
commit f458add
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/apps/settings/lib/SetupChecks/DatabaseHasMissingColumns.php b/apps/settings/lib/SetupChecks/DatabaseHasMissingColumns.php
@@ -81,7 +81,7 @@ public function run(): SetupResult {
 			foreach ($missingColumns as $missingColumn) {
 				$list .= "\n".$this->l10n->t('Missing optional column "%s" in table "%s".', [$missingColumn['columnName'], $missingColumn['tableName']]);
 			}
-			return SetupResult::info(
+			return SetupResult::warning(
 				$this->l10n->t('The database is missing some optional columns. Due to the fact that adding columns on big tables could take some time they were not added automatically when they can be optional. By running "occ db:add-missing-columns" those missing columns could be added manually while the instance keeps running. Once the columns are added some features might improve responsiveness or usability.').$list
 			);
 		}

diff --git a/apps/settings/lib/SetupChecks/DatabaseHasMissingIndices.php b/apps/settings/lib/SetupChecks/DatabaseHasMissingIndices.php
@@ -81,7 +81,7 @@ public function run(): SetupResult {
 			foreach ($missingIndices as $missingIndex) {
 				$list .= "\n".$this->l10n->t('Missing optional index "%s" in table "%s".', [$missingIndex['indexName'], $missingIndex['tableName']]);
 			}
-			return SetupResult::info(
+			return SetupResult::warning(
 				$this->l10n->t('The database is missing some indexes. Due to the fact that adding indexes on big tables could take some time they were not added automatically. By running "occ db:add-missing-indices" those missing indexes could be added manually while the instance keeps running. Once the indexes are added queries to those tables are usually much faster.').$list
 			);
 		}

diff --git a/apps/settings/lib/SetupChecks/DatabaseHasMissingPrimaryKeys.php b/apps/settings/lib/SetupChecks/DatabaseHasMissingPrimaryKeys.php
@@ -81,7 +81,7 @@ public function run(): SetupResult {
 			foreach ($missingPrimaryKeys as $missingPrimaryKey) {
 				$list .= "\n".$this->l10n->t('Missing primary key on table "%s".', [$missingPrimaryKey['tableName']]);
 			}
-			return SetupResult::info(
+			return SetupResult::warning(
 				$this->l10n->t('The database is missing some primary keys. Due to the fact that adding primary keys on big tables could take some time they were not added automatically. By running "occ db:add-missing-primary-keys" those missing primary keys could be added manually while the instance keeps running.').$list
 			);
 		}