fix(s3): Add config option to disable multipart copy for certain s3 p…

…roviders Signed-off-by: Julius Härtl <jus@bitgrid.net>
nextcloud · Dec 29, 2023 · f5fe531 · f5fe531
1 parent ad5be4f
commit f5fe531
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/private/Files/ObjectStore/S3ConnectionTrait.php b/lib/private/Files/ObjectStore/S3ConnectionTrait.php
@@ -74,6 +74,8 @@ trait S3ConnectionTrait {
 	/** @var int */
 	private $copySizeLimit;
 
+	private bool $useMultipartCopy = true;
+
 	protected $test;
 
 	protected function parseParams($params) {
@@ -91,6 +93,7 @@ protected function parseParams($params) {
 		$this->uploadPartSize = $params['uploadPartSize'] ?? 524288000;
 		$this->putSizeLimit = $params['putSizeLimit'] ?? 104857600;
 		$this->copySizeLimit = $params['copySizeLimit'] ?? 5242880000;
+		$this->useMultipartCopy = (bool)($params['useMultipartCopy'] ?? true);
 		$params['region'] = empty($params['region']) ? 'eu-west-1' : $params['region'];
 		$params['hostname'] = empty($params['hostname']) ? 's3.' . $params['region'] . '.amazonaws.com' : $params['hostname'];
 		if (!isset($params['port']) || $params['port'] === '') {

diff --git a/lib/private/Files/ObjectStore/S3ObjectTrait.php b/lib/private/Files/ObjectStore/S3ObjectTrait.php
@@ -198,7 +198,7 @@ public function copyObject($from, $to, array $options = []) {
 
 		$size = (int)($sourceMetadata->get('Size') ?? $sourceMetadata->get('ContentLength'));
 
-		if ($size > $this->copySizeLimit) {
+		if ($this->useMultipartCopy && $size > $this->copySizeLimit) {
 			$copy = new MultipartCopy($this->getConnection(), [
 				"source_bucket" => $this->getBucket(),
 				"source_key" => $from