-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings icons are color inverted based on wrong metrix #41352
Comments
I think the problem is rather that the icons are loaded via url and cannot be inverted thus... |
But they are inverted, just using the wrong "foundation" color to decide if it should be inverted. as per above I think we just need to add a new constant which does the invert of the existing variable. |
And even better would be using |
I'll send the filter patch I mentioned above |
Patch at #41855 |
yes, but it would break the API so not an option atm |
Thanks Joas! :) |
The icons of the
app-navigation-*
are influenced by the dark/bright theme. However for the active entry this behaviour is wrong and it would always need to use the color ofvar(--color-primary-element-text)
instead of a filtervar(--background-invert-if-dark)
Basically we need the opposite of
server/apps/theming/lib/Themes/CommonThemeTrait.php
Line 55 in 3378a73
The text was updated successfully, but these errors were encountered: