Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theming): Fix color inverted icons based on theming and dark mode #41855

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

nickvergessen
Copy link
Member

Summary

Mode Before After
Bright mode + text-on-primary "white" Bildschirmfoto vom 2023-11-29 11-23-17 Bildschirmfoto vom 2023-11-29 11-26-21
Dark mode + text-on-primary "white" Bildschirmfoto vom 2023-11-29 11-23-23 Bildschirmfoto vom 2023-11-29 11-26-17
Bright mode + text-on-primary "black" Bildschirmfoto vom 2023-11-29 11-29-01 Bildschirmfoto vom 2023-11-29 11-26-54
Dark mode + text-on-primary "black" Bildschirmfoto vom 2023-11-29 11-28-46 Bildschirmfoto vom 2023-11-29 11-26-59

Checklist

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this @nickvergessen! :)

Tested and seems to work fine but found one remaining spot where it is broken:
image

@AndyScherzinger
Copy link
Member

/backport to stable28

@nickvergessen
Copy link
Member Author

Found and fixed the user header menu and the arrow-down/up option for the nested share files list:

Bildschirmfoto vom 2023-11-29 11-56-48
Bildschirmfoto vom 2023-11-29 11-58-18

@szaimen
Copy link
Contributor

szaimen commented Nov 29, 2023

Nodb failure seems related https://drone.nextcloud.com/nextcloud/server/45036/9/4

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/41352/fix-settings-app-icons branch from 45644e7 to d05a13f Compare November 29, 2023 15:38
@nickvergessen nickvergessen merged commit a5a49ff into master Nov 29, 2023
50 checks passed
@nickvergessen nickvergessen deleted the bugfix/41352/fix-settings-app-icons branch November 29, 2023 20:10
@nickvergessen
Copy link
Member Author

/backport to stable28

@szaimen
Copy link
Contributor

szaimen commented Nov 30, 2023

Seems like it didnt work :/

@nickvergessen
Copy link
Member Author

Compiled assets... will do manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings icons are color inverted based on wrong metrix
3 participants