Fix preview generator trying to recreate an existing folder #32315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable24 |
|
/backport to stable23 |
|
/backport to stable22 |
CarlSchwan
approved these changes
May 9, 2022
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
fix/noid/preview-duplicate-folder-creation
branch
from
bb0a69b to
982c846
Compare
come-nc
approved these changes
May 10, 2022
skjnldsv
added
4. to release
|
The backport to stable23 failed. Please do this backport manually. |
st3iny
added a commit
that referenced
this pull request
May 10, 2022
Backport of #32315 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
|
The backport to stable22 failed. Please do this backport manually. |
st3iny
added a commit
that referenced
this pull request
May 10, 2022
Backport of #32315 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nextcloud/previewgenerator#289
The call to
$file->getId()might throw aNotFoundExceptionwhich is interpreted as a missing directory in the try/catch block. The catch block then tried to recreate the directory even though it's already existing.This patch was tested by the community via nextcloud/previewgenerator#289 (comment) and nextcloud/previewgenerator#289 (comment)