Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(navigation): Request user avatar in 64px/512px #36377

Closed

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jan 26, 2023

Resolves:

{"reqId":"wfo0ZhmZNBDzXGliaakN","level":0,"time":"2023-01-26T09:32:37+00:00","remoteAddr":"127.0.0.1","user":"admin","app":"core","method":"GET","url":"/avatar/admin/32?v=4","message":"Avatar requested in deprecated size 32","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Firefox/108.0","version":"26.0.0.2","data":{"app":"core"}}

Summary

Leftover of #33752.

TODO

  • Fix the deprecation log message

Checklist

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews labels Jan 26, 2023
@ChristophWurst ChristophWurst added this to the Nextcloud 26 milestone Jan 26, 2023
@ChristophWurst ChristophWurst self-assigned this Jan 26, 2023
@ChristophWurst
Copy link
Member Author

/backport to stable25

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 26, 2023
@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@szaimen
Copy link
Contributor

szaimen commented Mar 15, 2023

The user menu was redone in nextcloud/vue in the meantime so no need to do this anymore.

@szaimen szaimen closed this Mar 15, 2023
@szaimen szaimen deleted the fix/navigation/request-64px-user-avatar branch March 15, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
Development

Successfully merging this pull request may close these issues.

5 participants