Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable dependabot for cs-fixer, openapi-extractor and psalm #40097

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Aug 29, 2023

Summary

Enable dependabot for cs-fixer, openapi-extractor and psalm.

Each vendor-bin directory is an independent composer project, and therefore we need a dependabot configuration.

I wondered why cs:fixer did not support PHP 8.2 already.

composer run cs:fix
> php-cs-fixer fix
PHP needs to be a minimum version of PHP 7.4.0 and maximum version of PHP 8.1.*.
Current PHP version: 8.2.9.
To ignore this requirement please set `PHP_CS_FIXER_IGNORE_ENV`.
If you use PHP version higher than supported, you may experience code modified in a wrong way.

TODO

  • Merge
  • Expect a couple of bumps next week

Checklist

@kesselb kesselb requested review from skjnldsv, come-nc, a team and provokateurin August 29, 2023 12:35
@kesselb kesselb self-assigned this Aug 29, 2023
@kesselb kesselb added this to the Nextcloud 28 milestone Aug 29, 2023
@nickvergessen
Copy link
Member

As per #39271 we can't apply the updates at this point easily.
So not sure it makes sense to add dependabot already

@kesselb kesselb modified the milestones: Nextcloud 28, Nextcloud 29 Aug 30, 2023
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@skjnldsv skjnldsv force-pushed the dependabot-vendor-bin branch from cc19257 to 24b9072 Compare February 24, 2024 16:25
@skjnldsv
Copy link
Member

To merge or not to merge @kesselb ?

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 24, 2024
@kesselb
Copy link
Contributor Author

kesselb commented Feb 26, 2024

Merge please because the code style adjustments are done and therefore this should work now.

At worst, we are getting a few dependabot pull requests and figure that it does not work yet 🙈

@kesselb kesselb merged commit 1baedaf into master Feb 26, 2024
98 checks passed
@kesselb kesselb deleted the dependabot-vendor-bin branch February 26, 2024 19:51
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish developer experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants