Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(files): add files_sharing indicator #40517

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 19, 2023

image
Ref: #39914
Closes #38156

Additional infos

It might be good to extend the action API to allow title on inline Actions 😁

@skjnldsv skjnldsv requested review from a team, susnux, Pytal, szaimen, artonge and lhsazevedo and removed request for a team September 19, 2023 22:20
@skjnldsv
Copy link
Member Author

For the icon reverse, I think @susnux worked on something related? 🤔
This can always be improved later anyway :)

@skjnldsv skjnldsv mentioned this pull request Sep 19, 2023
26 tasks
@skjnldsv skjnldsv force-pushed the feat/sharing-status branch 2 times, most recently from da292d5 to 1ebb7f8 Compare September 20, 2023 10:08
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@skjnldsv

This comment was marked as resolved.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 20, 2023
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit 4ddbc55 into master Sep 20, 2023
36 of 38 checks passed
@skjnldsv skjnldsv deleted the feat/sharing-status branch September 20, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: files feature: sharing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Sharing icon not displayed for files shared to the user
4 participants