Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(phonenumber): Add OCP wrapper for PhoneNumber utils library #40620

Merged
merged 3 commits into from
Sep 26, 2023
Merged

feat(phonenumber): Add OCP wrapper for PhoneNumber utils library #40620

merged 3 commits into from
Sep 26, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 25, 2023 •
edited
Loading

Summary

  • Extract current code that interacts with 3rdparty libphonenumber into an OCP wrapper, so it can be used savely by apps, e.g. Talk for the upcoming SIP dial-out.

Checklist

@nickvergessen
feat(phonenumber): Add OCP wrapper for PhoneNumber utils library
5092278 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(phonenumber): Use the newly introduced API to limit 3rdparty lib …
0956b49 
…usage

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added enhancement 3. to review Waiting for reviews technical debt feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Sep 25, 2023
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Sep 25, 2023
@nickvergessen nickvergessen self-assigned this Sep 25, 2023
@nickvergessen nickvergessen mentioned this pull request Sep 25, 2023
Closed
1 task
ChristophWurst

This comment was marked as resolved.

Sign in to view

@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Sep 25, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 25, 2023
View reviewed changes
lib/private/Accounts/AccountManager.php Fixed Show fixed Hide fixed
lib/private/Accounts/AccountManager.php Fixed Show fixed Hide fixed
apps/provisioning_api/lib/Controller/UsersController.php Dismissed Show dismissed Hide dismissed
apps/provisioning_api/lib/Controller/UsersController.php Dismissed Show dismissed Hide dismissed
@nickvergessen nickvergessen force-pushed the feat/noid/ocp-for-phonenumber-util branch from 4f7dc69 to 0956b49 Compare September 25, 2023 14:52
@nickvergessen
fix(phonenumber): Improve docs by adding input details
3b4c306 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen mentioned this pull request Sep 25, 2023
Merged
@nickvergessen
Copy link
Member Author

Docs in nextcloud/documentation#11147

@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Sep 25, 2023
@nickvergessen nickvergessen merged commit 23a2e34 into master Sep 26, 2023
37 checks passed
@nickvergessen nickvergessen deleted the feat/noid/ocp-for-phonenumber-util branch September 26, 2023 06:59
@nickvergessen nickvergessen mentioned this pull request Sep 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamapoor fsamapoor fsamapoor approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews enhancement feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @ChristophWurst @fsamapoor