Set visible label for input field

[JuliaKirschenheuter]

• Part of [BITV] 9.3.3.2/0.1 - Note: "Placeholder" attributes are not a substitute for visual labels - they disappear as soon as users start entering data. (1) #37082

Summary

Replace password dialog with dialog from nextcloud-password-confirmation library. No visual changes.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[ShGKme]

Looks a bit weird... Would it be valid here to use "This action requires you to confirm your password" as a label?

[JuliaKirschenheuter]

Looks a bit weird... Would it be valid here to use "This action requires you to confirm your password" as a label?

I think "This action requires you to confirm your password" is too long for a label. That would change width of modal window too.
Would you have some other suggestion? But actually we can do all improvements after a11y certification.

[JuliaKirschenheuter]

@nimishavijay would you approve it?

[nimishavijay]

Would using a password field with an internal label work?

Recording.2023-09-27.182535.mp4

If not, then I propose the following changes:

• Change heading to "Confirm your password"
• Change subline to "This action needs authentication"
• Use an external label, but on the same row as the input field

Done here: nextcloud-libraries/nextcloud-password-confirmation#605

[ShGKme]

@artonge Do you want to re-review after a large change?

[Pytal]

Still needs #40874

Otherwise good

[ShGKme]

Cypress users_modify seems to be a flaky test, works fine locally:

Another test is a known problem

[JuliaKirschenheuter]

failing tests are unrelated