New UI global search

[nfebe]

Resolves: #39162

[skjnldsv]

Quick code quality review, (while I know this is a very early state 😉 )

• console.xxxxx should be avoided and a logger used instead
• Tabs not spaces
• Please format your classes using the BEM format
• Please also document the various sections in your templates with html comments

I won't do a review of the code itself as I assume this will heavily change in the future :)

[github-advanced-security]

Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

[blizzz]

Not up to date with main branch. I guess it needs another rebase and compile 🤔

No, there are no conflicts on the compiled assets

[blizzz]

CI complains however:

ERROR: There is 1 use of triple dot instead of ellipsis:
At line 17 in file /drone/src/build/../core/src/views/GlobalSearchModal.vue

Does it refer to https://github.com/nextcloud/server/pull/40823/files#diff-72e59d550e6509240d3c7bad01689aa5d0f9ce1c3b530fb7a45100fedebf37ffR18 ? Should be replaced with … .

P.S.: There are also apparent "real" test failures in https://drone.nextcloud.com/nextcloud/server/43505/9/4

[nfebe]

/compile amend /

[marcoambrosini]

@fenn-cs I pushed the searchable list component for people. To add it to global search modal copy-paste this:

<!-- People search popover -->
    <SearchableList :label-text="t('core', 'Search people')"
	    :search-list="peopleSeclectProps.options"
	    :empty-content-text="t('core', 'Not found')">
	    <template #trigger>
		    <NcButton>
			    {{ t('core', 'People') }}
		    </NcButton>
	    </template>
    </SearchableList>

With a few tweaks, we should be able to easily adapt this for the apps too

[AndyScherzinger]

/compile amend /

[Altahrim]

Cypress failure unrelated (already in master)

[nfebe]

/compile amend /

[nfebe]

/compile /

[nfebe]

Bringing this down here, so it remains visible and easily transferable to a new ticket.

TODO

• Icon inversion which does not work well now since icons come in white or black instead of one consistent color. (Black icons turn white and white icons turn black, leading to to white on white background issues)
• Use the new people filter (selector) that @marcoambrosini is working on (Current people filter not completed) - DONE, however, NcPopover which is used has issues with closing triggers.
• Update back-end API (if ability not already present) to show "Search in App" dynamically.

---

From @ChristophWurst

BUG: Clicking outside the search modal needs two clicks on the magnifier icon to get the modal back.
BUG: Some app icons are white on white.
BUG: Modified timestamp bubbles change size on hover, have no pointing cursor.
BUG: Generally no feedback for no results.
BUG: Search people has white text on white background.
BUG: Search people has a tiny user bubble, barely wider than the avatar.
BUG: Search people No result goes to the top, overlaps other input.
BUG: Search people has no effect at all. The search string doesn't contain a person identifier.

[ChristophWurst]

And all of #40823 (comment)

[nfebe]

Thanks @ChristophWurst updated.