add some support for rename on case insensitive local filesystems #40935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that having proper support for case insensitive file systems is a significant amount of work |
|
Tested on I was able to reproduce the bug. It was fixed with configuration: occ conf:sys:set localstorage.caseInsensitive --type bool --value=true |
Altahrim
reviewed
Oct 17, 2023
juliusknorr
reviewed
Oct 17, 2023
juliusknorr
reviewed
Oct 17, 2023
kesselb
reviewed
Oct 18, 2023
icewind1991
force-pushed
the
local-case-insensitive
branch
from
57718fb to
b157e56
Compare
Altahrim
reviewed
Oct 20, 2023
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
local-case-insensitive
branch
from
b157e56 to
8418fcf
Compare
Altahrim
approved these changes
Oct 20, 2023
juliusknorr
approved these changes
Oct 20, 2023
Merged
Merged
|
/backport to stable27 |
|
/backport to stable26 |
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some logic for handling case insensitive filesystems when
localstorage.case_insensitiveis set.This adds a bunch of overhead as
file_existsnow needs to read the directory content to perform the case sensitive compare.With my local testing (case insensitive zfs), the
rename('foo', 'Foo')call returns true but doesn't actually change the on-disk name, so an additional check is added that the name has actually changed. So the rename fails but at least doesn't cause a filecache desync.