Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic metadata request on PROPFIND requests #40964

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Oct 18, 2023

Depends on #40761
Part of #40676

Changes

  • Delete old metadata API files
  • Add support for getting metadata in PROPFIND request
  • Add support for setting metadata in PROPPATCH request

Test requests

curl 'https://nextcloud_server1.test/remote.php/dav/files/admin/img.jpg' \
  --insecure \
  --user admin:password \
  --request PROPFIND \
  --data '<?xml version="1.0" encoding="UTF-8"?>
    <d:propfind xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns">
      <d:prop>
        <d:getlastmodified/>
        <d:getcontentlength/>
        <d:getcontenttype/>
        <nc:metadata-files-test/>
      </d:prop>
    </d:propfind>' | xq
curl 'https://nextcloud_server1.test/remote.php/dav/files/admin/img.jpg' \
  --insecure \
  --user admin:password \
  --request PROPPATCH \
  --data '<?xml version="1.0" encoding="UTF-8"?>
    <d:propertyupdate xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns">
      <d:set>
            <d:prop>
              <nc:metadata-files-test>2</nc:metadata-files-test>
            </d:prop>
      </d:set>
    </d:propertyupdate>' | xq

@artonge artonge added 2. developing Work in progress feature: files php Pull requests that update Php code labels Oct 18, 2023
@artonge artonge added this to the Nextcloud 28 milestone Oct 18, 2023
@artonge artonge self-assigned this Oct 18, 2023
@artonge artonge force-pushed the artonge/feat/metadata/port_providers branch 2 times, most recently from ca2e7e3 to c35fea8 Compare October 19, 2023 11:51
@artonge artonge force-pushed the artonge/feat/metadata/port_providers branch 2 times, most recently from 0b37ac4 to 7e761c8 Compare October 19, 2023 13:12
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/files-metadata branch from 15cdbe8 to c89df97 Compare October 22, 2023 11:21
@artonge artonge force-pushed the artonge/feat/metadata/port_providers branch 4 times, most recently from 6294c15 to 34daa84 Compare October 25, 2023 16:16
@artonge artonge mentioned this pull request Oct 26, 2023
29 tasks
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/files-metadata branch from 1b13b8e to 683ef89 Compare October 26, 2023 13:24
@artonge artonge force-pushed the artonge/feat/metadata/port_providers branch 7 times, most recently from 54def10 to fff3fb6 Compare October 26, 2023 16:14
@artonge artonge marked this pull request as ready for review October 26, 2023 16:15
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/files-metadata branch 2 times, most recently from 5929e7e to ecd4bd1 Compare October 27, 2023 11:46
@artonge artonge force-pushed the artonge/feat/metadata/port_providers branch 3 times, most recently from e5333dc to 404d251 Compare November 6, 2023 15:10
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/files-metadata branch 2 times, most recently from 1065e8a to 2fc9ba3 Compare November 6, 2023 15:48
@blizzz blizzz mentioned this pull request Nov 6, 2023
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/files-metadata branch 2 times, most recently from 7205ff1 to f497d8b Compare November 7, 2023 13:43
Base automatically changed from enh/noid/files-metadata to master November 7, 2023 16:55
@artonge artonge force-pushed the artonge/feat/metadata/port_providers branch 5 times, most recently from 70545e3 to ba3a950 Compare November 8, 2023 11:11
core/Application.php Outdated Show resolved Hide resolved
apps/dav/lib/Connector/Sabre/FilesPlugin.php Outdated Show resolved Hide resolved
lib/public/Files/FileInfo.php Outdated Show resolved Hide resolved
apps/dav/lib/Connector/Sabre/FilesPlugin.php Outdated Show resolved Hide resolved
@artonge artonge force-pushed the artonge/feat/metadata/port_providers branch 6 times, most recently from 2447b62 to 015b3c4 Compare November 8, 2023 13:46
lib/private/Files/Cache/Cache.php Show resolved Hide resolved
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/feat/metadata/port_providers branch from 015b3c4 to d3a313f Compare November 8, 2023 15:24
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv skjnldsv added the pending documentation This pull request needs an associated documentation update label Nov 8, 2023
@artonge artonge enabled auto-merge November 8, 2023 16:28
@artonge artonge merged commit 77c9550 into master Nov 8, 2023
50 checks passed
@artonge artonge deleted the artonge/feat/metadata/port_providers branch November 8, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress feature: files pending documentation This pull request needs an associated documentation update php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants