-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML Validation: Personal settings #40983
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
force-pushed
the
fix/37092/personal-settings--html-validation
branch
from
October 19, 2023 17:16
e44ebd3
to
836f369
Compare
ShGKme
requested review from
Pytal,
susnux,
JuliaKirschenheuter,
julien-nc and
szaimen
October 19, 2023 17:17
Pytal
approved these changes
Oct 19, 2023
susnux
approved these changes
Oct 19, 2023
JuliaKirschenheuter
approved these changes
Oct 20, 2023
Empty string `''` is still rendered and is not a valid ID. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
There was a typo, it must have been disable-menu, not disableD-menu. But it is not required, because the menu is disabled for the current user anyway. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
There is no placeholder attribute on select element Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
…gs page If was replaced with universal `savePrimaryAccountPropertyScope`. `<HeaderBar>` has no `handle-scope-change` prop. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
susnux
force-pushed
the
fix/37092/personal-settings--html-validation
branch
from
October 20, 2023 18:34
836f369
to
7c142c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a number of small HTML validation issues on the Personal settings page.
See by commits.
Error: Bad value for attribute
aria-describedby
on elementinput
: An IDREFS value must contain at least one non-whitespace character.fix(settings): remove empty aria-describedby
Empty string
''
was set when there is no ID. But empty string is still rendered in Vue and is not a valid ID. Replaced withundefiend
.No visual changes.
Before:
After:
Error: The value of the
for
attribute of thelabel
element must be the ID of a non-hidden form control.fix(settings): fix ids and aria-labels in personal emails
Email elements had different ways to assign IDs and additional emails had no labels at all.
Now it is passed the same way as in other sections.
Error: Attribute
disabled-menu
not allowed on elementdiv
at this point.fix(settings): remove invalid avatar prop
There was a typo, it must have been
disable-menu
, notdisableD-menu
.But it is not required because the menu is disabled for the current user anyway.
No visual changes:
Error: Attribute
disabled-tooltip
not allowed on elementdiv
at this point.fix(settings): typo in avatar prop
disabled-tooltip
->disable-tooltip
Error: Attribute
placeholder
not allowed on elementselect
at this point.fix(settings): remove placeholder from select.
<select>
doesn't supportplaceholder
in HTMLNo visual changes:
Error: Attribute
handle-scope-change
not allowed on elementdiv
at this point.fix(settings): remove unused savePrimaryEmailScope on Personal Settings page
If was replaced with universal
savePrimaryAccountPropertyScope
before already. This method was unused and<HeaderBar>
has nohandle-scope-change
prop.Just removed.
Checklist