Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Only run tests on CI that are needed #40986

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix(tests): Only run tests on CI that are needed #40986

merged 1 commit into from
Oct 27, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 19, 2023 •
edited
Loading

Summary

Do not run PHP unit tests when only JS code is changed, should save us some CI time.

TODO

  • Make node-test-summary required instead of jsunit, handlebars and test (node test)

Checklist

@susnux susnux added 3. to review Waiting for reviews CI labels Oct 19, 2023
@susnux susnux force-pushed the fix/only-run-ci-that-is-needed branch from 1ed5fbe to 725bbd6 Compare October 19, 2023 14:54
@susnux susnux force-pushed the fix/only-run-ci-that-is-needed branch from 725bbd6 to e66b83b Compare October 19, 2023 20:38
@susnux susnux requested a review from nickvergessen October 19, 2023 20:39
@pulsejet pulsejet removed their request for review October 19, 2023 21:27
@pulsejet
Copy link
Member

Don't know enough about this part

@susnux susnux force-pushed the fix/only-run-ci-that-is-needed branch from e66b83b to 22e9b2c Compare October 20, 2023 15:11
@susnux susnux force-pushed the fix/only-run-ci-that-is-needed branch 2 times, most recently from 416d3ad to 4ac25b2 Compare October 20, 2023 18:17
@susnux
Copy link
Contributor Author

susnux commented Oct 20, 2023

I think this is good now :)
Drone is unrelated 😉

@solracsf solracsf added this to the Nextcloud 28 milestone Oct 27, 2023
@susnux
fix(tests): Only run tests on CI that are needed
cbefae7 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/only-run-ci-that-is-needed branch from 4ac25b2 to cbefae7 Compare October 27, 2023 11:50
@nickvergessen nickvergessen merged commit 66f7639 into master Oct 27, 2023
27 of 28 checks passed
@nickvergessen nickvergessen deleted the fix/only-run-ci-that-is-needed branch October 27, 2023 11:52
@susnux susnux mentioned this pull request Oct 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review Waiting for reviews CI
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@susnux @pulsejet @nickvergessen @skjnldsv @solracsf