Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files: fix virtual list will-change value (60fps superpowers) #40999

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

pulsejet
Copy link
Member

Follow up of #40958

I got the will-change wrong previously; it's the table that's scrolling, not the tbody. The performance with this patch is absolutely insane (we might want to increase the buffer a bit from 3 though). It's so good, actually, that I'm considering making this scroller into a standalone library (unless there's already a plan for that).

Here's how the updates during scrolling look like:

Before After
wc_before wc_after

@pulsejet pulsejet requested review from susnux and skjnldsv October 19, 2023 20:00
@pulsejet pulsejet added this to the Nextcloud 28 milestone Oct 19, 2023
@pulsejet pulsejet added the 3. to review Waiting for reviews label Oct 19, 2023
@pulsejet
Copy link
Member Author

Note: I noticed this is somewhat browser dependent. Firefox seems to already have been detecting and applying this optimization. So the main difference here is for Chromium (and maybe WebKit)

@susnux
Copy link
Contributor

susnux commented Oct 19, 2023

Nice! 🚀

But please fix the missing signoff 😉

@pulsejet pulsejet force-pushed the files-list-will-change branch from 28378e7 to 5b91fb1 Compare October 19, 2023 20:12
@pulsejet
Copy link
Member Author

pulsejet commented Oct 19, 2023

But please fix the missing signoff 😉

Argh not again 😩 .. done!

we might want to increase the buffer a bit from 3 though

need opinion on this btw, if anyone can test scrolling fast in a large directory. I think 5 or 6 might be good (EDIT: or maybe it's not that important ... can't see a lot of difference)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 20, 2023
@skjnldsv
Copy link
Member

need opinion on this btw, if anyone can test scrolling fast in a large directory. I think 5 or 6 might be good (EDIT: or maybe it's not that important ... can't see a lot of difference)

All my tests and development over the last months have been done on a 1k images folder :)

@skjnldsv skjnldsv force-pushed the files-list-will-change branch from 5b91fb1 to 9ac365d Compare October 20, 2023 08:30
@skjnldsv
Copy link
Member

/compile amend /

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member

@pulsejet your commit names doesn't follow conventional commits
files: fix virtual list will-change value should be fix(files): virtual list will-change value (adjusted)

@skjnldsv skjnldsv force-pushed the files-list-will-change branch from 9ac365d to 2db1eab Compare October 20, 2023 08:50
@skjnldsv skjnldsv merged commit e49353d into master Oct 20, 2023
38 of 42 checks passed
@skjnldsv skjnldsv deleted the files-list-will-change branch October 20, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish performance 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants