-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
files: fix virtual list will-change value (60fps superpowers) #40999
Conversation
Note: I noticed this is somewhat browser dependent. Firefox seems to already have been detecting and applying this optimization. So the main difference here is for Chromium (and maybe WebKit) |
Nice! 🚀 But please fix the missing signoff 😉 |
28378e7
to
5b91fb1
Compare
Argh not again 😩 .. done!
need opinion on this btw, if anyone can test scrolling fast in a large directory. I think 5 or 6 might be good (EDIT: or maybe it's not that important ... can't see a lot of difference) |
All my tests and development over the last months have been done on a 1k images folder :) |
5b91fb1
to
9ac365d
Compare
/compile amend / |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@pulsejet your commit names doesn't follow conventional commits |
9ac365d
to
2db1eab
Compare
Follow up of #40958
I got the
will-change
wrong previously; it's the table that's scrolling, not thetbody
. The performance with this patch is absolutely insane (we might want to increase the buffer a bit from 3 though). It's so good, actually, that I'm considering making this scroller into a standalone library (unless there's already a plan for that).Here's how the updates during scrolling look like: