-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(user_status): separate user menu and dashboard status layout for HTML validation #41068
Merged
JuliaKirschenheuter
merged 2 commits into
master
from
fix/37092/user-status--html-validation
Oct 24, 2023
Merged
fix(user_status): separate user menu and dashboard status layout for HTML validation #41068
JuliaKirschenheuter
merged 2 commits into
master
from
fix/37092/user-status--html-validation
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
approved these changes
Oct 23, 2023
- Remove href="#" from a button for HTML validation - Use @nextcloud/vue NcButton instead of custom button in Dashboard Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/37092/user-status--html-validation
branch
from
October 24, 2023 09:00
d68e6e0
to
bec2d43
Compare
Rebased onto master, resolved assets conflicts |
JuliaKirschenheuter
approved these changes
Oct 24, 2023
susnux
approved these changes
Oct 24, 2023
failed Cypress is unrelated |
JuliaKirschenheuter
deleted the
fix/37092/user-status--html-validation
branch
October 24, 2023 13:35
/backport to stable28 |
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
This PR was done before 29, it is in 28 already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UserStatus
component is used in both User Menu (2 entries) and Dashboard status widget. It reuses layout, but the usage is quite different.TODO
href="#"
from a button for HTML validation@nextcloud/vue
NcButton
instead of custom button in Dashboard for better looking (status icon is in the center, button size is the same as other buttons)Checklist