Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user_status): separate user menu and dashboard status layout for HTML validation #41068

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 23, 2023

Error: Attribute href not allowed on element button at this point.

Summary

UserStatus component is used in both User Menu (2 entries) and Dashboard status widget. It reuses layout, but the usage is quite different.

User Menu Entries Dashboard Status Widget
image image

TODO

  • Separate layout for user menu and dashboard. This allows to:
    • Remove href="#" from a button for HTML validation
    • Use @nextcloud/vue NcButton instead of custom button in Dashboard for better looking (status icon is in the center, button size is the same as other buttons)
Before After
image image

Checklist

@ShGKme ShGKme added this to the Nextcloud 28 milestone Oct 23, 2023
@ShGKme ShGKme self-assigned this Oct 23, 2023
@Pytal Pytal linked an issue Oct 23, 2023 that may be closed by this pull request
- Remove href="#" from a button for HTML validation
- Use @nextcloud/vue NcButton instead of custom button in Dashboard

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/37092/user-status--html-validation branch from d68e6e0 to bec2d43 Compare October 24, 2023 09:00
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 24, 2023

Rebased onto master, resolved assets conflicts

@JuliaKirschenheuter
Copy link
Contributor

failed Cypress is unrelated

@JuliaKirschenheuter JuliaKirschenheuter merged commit 970ac3d into master Oct 24, 2023
40 of 43 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/37092/user-status--html-validation branch October 24, 2023 13:35
@JuliaKirschenheuter
Copy link
Contributor

/backport to stable28

@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 27, 2023

/backport to stable28

This PR was done before 29, it is in 28 already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV] User menu set status button
4 participants