Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate checks to new SetupCheck API #41134

Merged
merged 12 commits into from
Nov 7, 2023
Merged

Migrate checks to new SetupCheck API #41134

merged 12 commits into from
Nov 7, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Oct 26, 2023 •
edited
Loading

Summary

Migrate more checks to new SetupCheck API.
Screenshot_20231107_100427

TODO

Checklist

@come-nc come-nc added the 2. developing Work in progress label Oct 26, 2023
@come-nc come-nc self-assigned this Oct 26, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 26, 2023
View reviewed changes
apps/settings/lib/Controller/CheckSetupController.php
ITempManager $tempManager,
IManager $manager,
IAppManager $appManager,
IServerContainer $serverContainer,

Check notice

Code scanning / Psalm

DeprecatedInterface Note

Interface OCP\IServerContainer is marked as deprecated
@come-nc come-nc added this to the Nextcloud 28 milestone Oct 26, 2023
@come-nc come-nc force-pushed the feat/add-occ-command-for-setupchecks branch from c76554a to 77ab31d Compare October 26, 2023 12:24
@come-nc come-nc force-pushed the feat/migrate-more-setup-checks branch from 3db1039 to 4e15cbd Compare October 26, 2023 13:31
@come-nc come-nc changed the title Migrate getenv test to new SetupCheck API Migrate checks to new SetupCheck API Oct 26, 2023
@come-nc come-nc force-pushed the feat/migrate-more-setup-checks branch from 5485f89 to c9b276b Compare October 26, 2023 14:11
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@come-nc come-nc force-pushed the feat/migrate-more-setup-checks branch from 6397704 to 09badc8 Compare November 6, 2023 14:25
@come-nc come-nc force-pushed the feat/add-occ-command-for-setupchecks branch from 4d6d12b to 2aab6bd Compare November 6, 2023 14:26
@come-nc come-nc force-pushed the feat/migrate-more-setup-checks branch from 09badc8 to f1cc337 Compare November 6, 2023 14:31
Base automatically changed from feat/add-occ-command-for-setupchecks to master November 6, 2023 16:27
@come-nc come-nc mentioned this pull request Nov 6, 2023
Merged
6 tasks
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 6, 2023
@come-nc come-nc marked this pull request as ready for review November 6, 2023 16:52
@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
@come-nc come-nc force-pushed the feat/migrate-more-setup-checks branch from 95601d4 to 57ce25e Compare November 7, 2023 09:06
@come-nc come-nc requested review from susnux, szaimen, a team, ArtificialOwl, icewind1991 and nfebe and removed request for a team November 7, 2023 09:06
@come-nc come-nc force-pushed the feat/migrate-more-setup-checks branch from 57ce25e to bd59ffc Compare November 7, 2023 09:08
@come-nc
Migrate getenv test to new SetupCheck API
dec52f6 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Remove duplicated ReadOnlyConfig setup check
506f396 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate email test to new SetupCheck API
5957a2b 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate database transaction level check to SetupCheck API
3c75075 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Remove duplicate fileinfo PHP module check
f9770b8 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrated both file locking checks to SetupCheck API
6911dc3 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate memcache check to SetupCheck API
ddd13a9 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate Randomness secure check to SetupCheck API
147b29f 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate code integrity to SetupCheck API
086d3ce 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate Freetype check to SetupCheck API
ac3da13 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate 32bit check to SetupCheck API
0fd5ed9 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Revert "Migrate code integrity to SetupCheck API"
00d3856 
This reverts commit aa2d315.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the feat/migrate-more-setup-checks branch from bd59ffc to 00d3856 Compare November 7, 2023 11:25
@susnux susnux merged commit 84d2a9b into master Nov 7, 2023
51 checks passed
@susnux susnux deleted the feat/migrate-more-setup-checks branch November 7, 2023 13:21
@come-nc come-nc mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigcat88 bigcat88 bigcat88 approved these changes

@Altahrim Altahrim Altahrim approved these changes

@susnux susnux susnux approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@szaimen szaimen Awaiting requested review from szaimen

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@come-nc @nickvergessen @susnux @Altahrim @bigcat88