Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cypress] Use GitHub action service for Nextcloud server #41252

Closed
wants to merge 2 commits into from
Closed

[cypress] Use GitHub action service for Nextcloud server #41252

wants to merge 2 commits into from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 3, 2023

Summary

Follow up on #41250

This changes the Cypress workflow to not start a docker container from Cypress but use a GitHub workflow service as the Nextcloud container.
This saves ~2 minutes CI time per Cypress runner (currently 3).

Also the service is up when the workflow starts meaning cypress does not have to wait for it and should no longer time out.

Checklist

@susnux susnux added 3. to review Waiting for reviews CI labels Nov 3, 2023
@susnux susnux mentioned this pull request Nov 3, 2023
Merged
4 tasks
Base automatically changed from chore/cypress-timeout to master November 3, 2023 02:07
@skjnldsv
Copy link
Member

skjnldsv commented Nov 3, 2023

This saves ~2 minutes CI time per Cypress runner (currently 3).

Do you know why? I mean, both are running docker? This look like a crazy difference 🤯

@susnux
Copy link
Contributor Author

susnux commented Nov 3, 2023

Do you know why? I mean, both are running docker? This look like a crazy difference 🤯

I guess because services are cached and created on the beginn while manually starting docker happens on step evaluation

@solracsf solracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@blizzz blizzz mentioned this pull request Nov 22, 2023
Merged
5 tasks
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
max-nextcloud
max-nextcloud approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach.

I'd be happy to save 2 min per cypress runner.

I'm wondering if there are any downsides to this but can't think of any. The only thing that comes to my mind is that we may need to maintain multiple images at some point so once this lands on stable branches they still have a container that works for them. But i guess we'll need the images anyway and can just configure them in the cypress.yml accordingly.

@susnux susnux force-pushed the core/cypress-use-github branch from a8edfaa to d5e8cc5 Compare January 20, 2024 15:05
@susnux susnux requested a review from skjnldsv January 20, 2024 15:05
@susnux susnux mentioned this pull request Jan 20, 2024
Merged
@susnux susnux force-pushed the core/cypress-use-github branch 2 times, most recently from 08461da to b21957d Compare January 20, 2024 16:28
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 21, 2024
@skjnldsv skjnldsv force-pushed the core/cypress-use-github branch from 39158c0 to 90b734f Compare January 21, 2024 09:46
@skjnldsv
Copy link
Member

Seems like it's failing much more randomly with that PR 🤔

@skjnldsv
Copy link
Member

navigation-bar-settings.cy.ts is really failing

@ChristophWurst ChristophWurst removed their request for review January 22, 2024 09:59
susnux and others added 2 commits February 23, 2024 15:03
@susnux @skjnldsv
fix(cypress): Use github action service for Nextcloud container
1f6ed9c 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv
fix(cypress): disable ci-build-id, group and tag until we have …
41f6c9f 
…a cypress cloud service again

Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the core/cypress-use-github branch from 90b734f to 41f6c9f Compare February 23, 2024 14:03
@skjnldsv skjnldsv enabled auto-merge February 23, 2024 14:31
@skjnldsv
Copy link
Member

skjnldsv commented Feb 23, 2024 •
edited
Loading

Error response from daemon: No such container: nextcloud-cypress-tests-server

Cypress failure handling needs a fix

@skjnldsv skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Feb 23, 2024
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@susnux susnux closed this May 31, 2024
auto-merge was automatically disabled May 31, 2024 16:11

Pull request was closed

@susnux susnux deleted the core/cypress-use-github branch May 31, 2024 16:11
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
2. developing Work in progress CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@susnux @skjnldsv @max-nextcloud @blizzz @solracsf