Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve .flac audio files #41541

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Serve .flac audio files #41541

merged 1 commit into from
Nov 16, 2023

Conversation

SystemKeeper
Copy link
Contributor

Summary

To support call sounds in Safari we need to use *.flac audio files, since *.ogg is not supported by Safari (nextcloud/spreed#9422). But currently *.flac files will not be served, so

https://.../apps/spreed/img/join_call.ogg -> works
https://.../apps/spreed/img/join_call.flac -> does not work

Since we added call sounds with 27, backport to stable27?

Checklist

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper requested review from nickvergessen, a team, ArtificialOwl, Altahrim and sorbaugh and removed request for a team November 16, 2023 13:28
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the nginx docs:
https://docs.nextcloud.com/server/stable/admin_manual/installation/nginx.html

    # Serve static files
    location ~ \.(?:css|js|mjs|svg|gif|png|jpg|ico|wasm|tflite|map)$ {

And add to https://docs.nextcloud.com/server/stable/admin_manual/release_notes/upgrade_to_27.html

@nickvergessen
Copy link
Member

/backport to stable27

@SystemKeeper
Copy link
Contributor Author

Please also update the nginx docs:

Done in nextcloud/documentation#11288

@susnux susnux added pending documentation This pull request needs an associated documentation update and removed pending documentation This pull request needs an associated documentation update labels Nov 16, 2023
@blizzz blizzz mentioned this pull request Nov 16, 2023
@SystemKeeper SystemKeeper merged commit db3c731 into master Nov 16, 2023
50 checks passed
@SystemKeeper SystemKeeper deleted the fix/noid/serve-flac-files branch November 16, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants