Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure DateTime conversion to string #41600

Closed
wants to merge 3 commits into from
Closed

fix: ensure DateTime conversion to string #41600

wants to merge 3 commits into from

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Nov 18, 2023 •
edited
Loading

Checklist

@solracsf
fix: ensure DateTime conversion to string
b49e576 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf added the 3. to review Waiting for reviews label Nov 18, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Nov 18, 2023
@solracsf
Fix psalm
66df68b 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 18, 2023
@solracsf
Psalm fix
f9ac7ec 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf closed this Nov 18, 2023
@solracsf solracsf deleted the DateTimeToString branch November 18, 2023 23:01
@solracsf solracsf removed the 2. developing Work in progress label Nov 18, 2023
@solracsf solracsf removed this from the Nextcloud 28 milestone Nov 18, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 18, 2023
View reviewed changes
apps/files_sharing/lib/Controller/ShareAPIController.php
* @throws \Exception
* @return \DateTime
*/
private function parseDate(string $expireDate): \DateTime {
private function parseDate($expireDate): \DateTime {

Check notice

Code scanning / Psalm

MissingParamType Note

Parameter $expireDate has no provided type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@solracsf