-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): remove focus outline on file list item click and make the link focusable #41619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from the videos, thanks! :)
753e8f3
to
59f183b
Compare
Updates:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks great design-wise!
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
…omponent - Special attribute `is` is deprecated and removed in Vue 3 - It is confusing, that `<a>` element is rendered as `span` sometimes Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
59f183b
to
c90ae20
Compare
Rebased onto master. |
/backport to stable28 |
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Summary
There is an outline on
focus-visible
state, which appears also on click making a glitch effect.At the same time,
focus-visible
state was not useful because the link was not focusable.Todo
tabindex
(links usually should not be focusable, but in this case it works close to the button)linkTo
: replace deprecatedis
attr on<a>
with a dynamic component:is
is deprecated and removed in Vue 3<a>
element is rendered as<span>
sometimesChecklist