Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling of Brute Force and other fixes #41642

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Conversation

Valdnet
Copy link
Contributor

@Valdnet Valdnet commented Nov 21, 2023

  1. Correcting the spelling of "Bruteforce" to "Brute Force".
  2. Adding quotation marks.
  3. Fixed a typo.

Correcting the spelling of "Bruteforce" to "Brute Force"

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@Valdnet Valdnet changed the title Correct spelling of Brute Force Correct spelling of Brute Force and other fixes Nov 21, 2023
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an english native speaker so I do not know about the change itself but the PR won’t break anything 👍

Copy link
Member

@rakekniven rakekniven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"brute-force" is correct from my pov. Can you double check?

@Valdnet
Copy link
Contributor Author

Valdnet commented Nov 21, 2023

"brute-force" is an alternative spelling of this word.

@solracsf solracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@rakekniven
Copy link
Member

rakekniven commented Nov 22, 2023

"brute-force" is an alternative spelling of this word.

I just did a search at Transifex

"brute-force" is an alternative spelling of this word.

Just did a search at Tx for the NC project:

Bruteforce: 6 results. You modified 3 of them here. 👍
Brute force: 1 result.
Brute-force: 3 results

For me, "brute force" or "brute-force" is fine. As long as we establish one (!) spelling and adapt all occurrences.

@blizzz blizzz mentioned this pull request Nov 22, 2023
5 tasks
@Valdnet
Copy link
Contributor Author

Valdnet commented Nov 22, 2023

I propose "Brute force" 😁.

@rakekniven
Copy link
Member

I propose "Brute force" 😁.

:-)

Have you seen https://en.wikipedia.org/wiki/Brute-force_search and the spelling there?

@Valdnet
Copy link
Contributor Author

Valdnet commented Nov 22, 2023

So we change it to "Brute-force" 😉.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@rakekniven
Copy link
Member

So we change it to "Brute-force" 😉.

Hahaha. Did not expect this change and had to adapt my other two PRs as well. Now it should be good.

@AndyScherzinger AndyScherzinger merged commit 83c6db4 into master Nov 22, 2023
49 of 50 checks passed
@AndyScherzinger AndyScherzinger deleted the Valdnet-patch-1 branch November 22, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants