-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct spelling of Brute Force and other fixes #41642
Conversation
Valdnet
commented
Nov 21, 2023
•
edited
Loading
edited
- Correcting the spelling of "Bruteforce" to "Brute Force".
- Adding quotation marks.
- Fixed a typo.
Correcting the spelling of "Bruteforce" to "Brute Force" Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an english native speaker so I do not know about the change itself but the PR won’t break anything 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"brute-force" is correct from my pov. Can you double check?
"brute-force" is an alternative spelling of this word. |
I just did a search at Transifex
Just did a search at Tx for the NC project: Bruteforce: 6 results. You modified 3 of them here. 👍 For me, "brute force" or "brute-force" is fine. As long as we establish one (!) spelling and adapt all occurrences. |
I propose "Brute force" 😁. |
:-) Have you seen https://en.wikipedia.org/wiki/Brute-force_search and the spelling there? |
So we change it to "Brute-force" 😉. |
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Hahaha. Did not expect this change and had to adapt my other two PRs as well. Now it should be good. |