Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix star stroke color on hover #41672

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Fix star stroke color on hover #41672

merged 1 commit into from
Nov 23, 2023

Conversation

marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Nov 23, 2023 •
edited
Loading

Summary

Before
Screenshot from 2023-11-23 14-54-11

After
Screenshot from 2023-11-23 14-53-43

TODO

  • ...

Checklist

@marcoambrosini marcoambrosini self-assigned this Nov 23, 2023
@marcoambrosini marcoambrosini added 3. to review Waiting for reviews bug labels Nov 23, 2023
@marcoambrosini marcoambrosini force-pushed the bugfix/4872/fix-star-stroke-color branch from c859518 to 20844d4 Compare November 23, 2023 05:58
@AndyScherzinger AndyScherzinger force-pushed the bugfix/4872/fix-star-stroke-color branch from 20844d4 to 18cd3e8 Compare November 23, 2023 08:20
@nextcloud-command nextcloud-command force-pushed the bugfix/4872/fix-star-stroke-color branch from 18cd3e8 to b2fb076 Compare November 23, 2023 08:23
@marcoambrosini @AndyScherzinger
Fix star stroke color on hover
accdb2d 
Signed-off-by: Marco Ambrosini <marcoambrosini@icloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger force-pushed the bugfix/4872/fix-star-stroke-color branch from b2fb076 to accdb2d Compare November 23, 2023 08:24
@AndyScherzinger
Copy link
Member

/compile amend /

szaimen
szaimen approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the screenshots

@szaimen szaimen added this to the Nextcloud 28 milestone Nov 23, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@AndyScherzinger
Copy link
Member

/backport to stable28

@AndyScherzinger AndyScherzinger merged commit ea9127c into master Nov 23, 2023
41 of 42 checks passed
@AndyScherzinger AndyScherzinger deleted the bugfix/4872/fix-star-stroke-color branch November 23, 2023 12:55
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 23, 2023
Merged
jancborchardt
jancborchardt reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks clean @marcoambrosini ✨

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

@szaimen szaimen szaimen approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

@artonge artonge Awaiting requested review from artonge

Assignees

@marcoambrosini marcoambrosini

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Background of favorite star border has different color on hover
6 participants
@marcoambrosini @AndyScherzinger @jancborchardt @JuliaKirschenheuter @szaimen @blizzz