-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mimetype for ReStructuredText #41684
Conversation
If you want to update the mime type for files already existing in oc_filecache an additional change for |
b1dbce3
to
922d529
Compare
I had assumed repair was a file preview thing. Added it now, thanks for the explanation. |
Yep. There should be a brief inline description in CheckerTest how to update it properly. |
922d529
to
f2dc43e
Compare
The CheckerTest did not update the |
f2dc43e
to
2d4e2a5
Compare
2d4e2a5
to
dca0477
Compare
Possible performance regression detected Show Output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK (and I very well can be wrong, so correct me if I am), this should not cause any problems with how we handle mimetyping in other parts of our frontend 👍 So if this version upgrade is really needed, then this looks good to me!
Conflicts @kyteinsky |
dca0477
to
ebef502
Compare
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
ebef502
to
8b0d493
Compare
Summary
Mimetype for re structured text. It is aliased to text.
There is no official mimetype for
.rst
files sotext/plain
can also work here.Checklist