Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mimetype for ReStructuredText #41684

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Add mimetype for ReStructuredText #41684

merged 1 commit into from
Mar 15, 2024

Conversation

kyteinsky
Copy link
Contributor

Summary

Mimetype for re structured text. It is aliased to text.
There is no official mimetype for .rst files so text/plain can also work here.

Checklist

@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
@blizzz blizzz added enhancement 3. to review Waiting for reviews labels Nov 23, 2023
@blizzz blizzz requested review from a team, ArtificialOwl, icewind1991 and sorbaugh and removed request for a team November 23, 2023 11:33
@kesselb
Copy link
Contributor

kesselb commented Nov 23, 2023

If you want to update the mime type for files already existing in oc_filecache an additional change for lib/private/Repair/RepairMimeTypes.php is necessary.

Example: https://github.com/nextcloud/server/pull/41395/files#diff-f89544ac76d4f0e2cd70b4979d625b3992a72fa26c6f0b5fe92ec0364b9716e9

@kyteinsky
Copy link
Contributor Author

I had assumed repair was a file preview thing. Added it now, thanks for the explanation.
Do the changes in tests/data/integritycheck/mimetypeListModified/core/js/mimetypelist.js also need to be pushed?

@kesselb
Copy link
Contributor

kesselb commented Nov 30, 2023

I had assumed repair was a file preview thing. Added it now, thanks for the explanation. Do the changes in tests/data/integritycheck/mimetypeListModified/core/js/mimetypelist.js also need to be pushed?

Yep.

There should be a brief inline description in CheckerTest how to update it properly.

@kyteinsky
Copy link
Contributor Author

The CheckerTest did not update the core/js/mimetypelist.js file, which was updated with ./occ maintenance:mimetype:update-js as mentioned in the file.

@kyteinsky kyteinsky requested review from kesselb and sorbaugh and removed request for ArtificialOwl, icewind1991 and sorbaugh February 6, 2024 06:16
Copy link
Contributor

Possible performance regression detected

Show Output
564 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test/new_file.txt
+ /remote.php/dav/files/test added with 45 queries
+ /remote.php/dav/files/test/test.txt added with 33 queries
+ /remote.php/dav/files/test/many_files added with 46 queries
+ /remote.php/dav/files/test/new_file.txt added with 67 queries
+ /remote.php/dav/files/test/new_file.txt added with 91 queries
+ /remote.php/dav/files/test added with 45 queries
+ /remote.php/dav/files/test/test.txt added with 33 queries
+ /remote.php/dav/files/test/many_files added with 46 queries
+ /remote.php/dav/files/test/new_file.txt added with 67 queries
+ /remote.php/dav/files/test/new_file.txt added with 91 queries

@kyteinsky kyteinsky requested a review from come-nc February 26, 2024 12:41
@come-nc come-nc requested review from a team, szaimen and emoral435 and removed request for a team February 26, 2024 14:01
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK (and I very well can be wrong, so correct me if I am), this should not cause any problems with how we handle mimetyping in other parts of our frontend 👍 So if this version upgrade is really needed, then this looks good to me!

version.php Outdated Show resolved Hide resolved
This was referenced Mar 12, 2024
@skjnldsv skjnldsv requested a review from emoral435 March 15, 2024 14:35
@skjnldsv
Copy link
Member

Conflicts @kyteinsky

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 15, 2024
@skjnldsv skjnldsv marked this pull request as draft March 15, 2024 14:35
@kyteinsky kyteinsky marked this pull request as ready for review March 15, 2024 14:49
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 15, 2024
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 15, 2024
@kyteinsky kyteinsky enabled auto-merge March 15, 2024 15:21
@kyteinsky kyteinsky merged commit 1111c3f into master Mar 15, 2024
169 checks passed
@kyteinsky kyteinsky deleted the feat/rst-mimetype branch March 15, 2024 16:49
@Altahrim Altahrim mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants