Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Allow to drag and drop new files also on empty directories #41693

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 23, 2023

Summary

  1. Move the drag and drop from the files table to the files list, to allow drag and drop upload in empty folders (where no table is shown but an empty content message). Also unregister the drag and drop listeners on component destroy, which was causing errors like this.$refs.table undefined.
  2. Fix the missing error message for drag and drop uploads on failure.
  3. Cleanup not used styles from the drag and drop notice.

Videos

Before

See that it is not possible to drop in empty folders

vokoscreenNG-2023-11-23_14-49-24.mp4

After

See that dropping is now possible in empty folders

vokoscreenNG-2023-11-23_14-48-17.mp4

Checklist

@susnux
Copy link
Contributor Author

susnux commented Nov 23, 2023

/backport to stable28

@susnux susnux force-pushed the fix/files-drag-and-drop branch from ce24e9a to b4639cc Compare November 23, 2023 14:00
@susnux susnux added this to the Nextcloud 29 milestone Nov 23, 2023
apps/files/src/components/FilesListVirtual.vue Outdated Show resolved Hide resolved
apps/files/src/views/FilesList.vue Outdated Show resolved Hide resolved
@susnux susnux requested a review from artonge November 23, 2023 16:08
@susnux susnux force-pushed the fix/files-drag-and-drop branch 2 times, most recently from daba85a to ef4ee28 Compare November 23, 2023 19:45
@susnux susnux self-assigned this Nov 23, 2023
@susnux susnux force-pushed the fix/files-drag-and-drop branch 2 times, most recently from d346f15 to c6dbcb3 Compare November 24, 2023 01:08
apps/files/tsconfig.json Outdated Show resolved Hide resolved
@susnux susnux force-pushed the fix/files-drag-and-drop branch 2 times, most recently from ba69aa5 to 2bbc4a2 Compare November 27, 2023 14:27
@susnux susnux requested a review from artonge November 27, 2023 14:27
@susnux susnux dismissed artonge’s stale review November 27, 2023 14:27

Resolved the comments

@AndyScherzinger
Copy link
Member

/compile amend /

@susnux susnux force-pushed the fix/files-drag-and-drop branch from 2bbc4a2 to 2c77922 Compare November 27, 2023 16:32
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…script in Vue files

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/files-drag-and-drop branch from 2c77922 to 7e48ea0 Compare November 27, 2023 16:36
@susnux susnux merged commit c54c6a8 into master Nov 27, 2023
42 checks passed
@susnux susnux deleted the fix/files-drag-and-drop branch November 27, 2023 18:06
@susnux
Copy link
Contributor Author

susnux commented Dec 1, 2023

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
6 participants