-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nextcloud 27 : Replace "Update" with "Edit" in share dialog #41734
Nextcloud 27 : Replace "Update" with "Edit" in share dialog #41734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original commit has the word update in two places... Does it already exist in once place here?
@fenn-cs
... but in don't think I need or have to change it because it's apparently not a wording call. What do you think ? |
I see where the issue is coming from.... #41301 was never backported so
Which you updated in master does not exist in stable27. cc: @Jerome-Herbinet |
@Jerome-Herbinet Can you please rebase against this and add the update? #41736 |
I rebased but there are unnecessary commits. I'll fix it tomorrow. |
6723b5a
to
6015471
Compare
/compile amend / |
404550f
to
ac2a3a0
Compare
Hi @AndyScherzinger :) I would like to know : the owner of the PR is able to use the Bot Nextcloud? I guess your command allows you to build assets and merge with this branch, no? |
@zak39 yes, well anybody can
yes, while you can also leave out the amending, that will just amend the compiled assets with the last commit of the PR. So depending on the decision you might not want that. |
/compile amend / |
5ff3268
to
cc7c2a5
Compare
4856988
to
912138e
Compare
/compile amend / |
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
912138e
to
21c157e
Compare
Drone failure unrelated. |
Same as #41680 but specially made for NC 27 because backport failed.
Checklist