Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dav): Make ooo settings a form and the message required #41759

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix(dav): Make ooo settings a form and the message required #41759

merged 1 commit into from
Nov 29, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 27, 2023 •
edited
Loading

Summary

  • Converts the elements to a HTML-native form
  • Make the message mandatory
  • Add success toasts
  • Log errors

Checklist

@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews feature: dav feature: caldav Related to CalDAV internals labels Nov 27, 2023
@ChristophWurst ChristophWurst added this to the Nextcloud 29 milestone Nov 27, 2023
@ChristophWurst ChristophWurst self-assigned this Nov 27, 2023
@ChristophWurst
Copy link
Member Author

/backport to stable28

st3iny
st3iny approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

Compiled assets are missing though.

@ChristophWurst
fix(dav): Make ooo settings a form and the message required
ecc1576 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 27, 2023
@ChristophWurst ChristophWurst force-pushed the fix/dav/ooo-form-mandatory-message branch from 9229547 to ecc1576 Compare November 27, 2023 17:41
auto-merge was automatically disabled November 27, 2023 20:17

Pull Request is not mergeable

@ChristophWurst ChristophWurst merged commit 4d2a32a into master Nov 29, 2023
42 checks passed
@ChristophWurst ChristophWurst deleted the fix/dav/ooo-form-mandatory-message branch November 29, 2023 07:54
@ChristophWurst
Copy link
Member Author

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 29, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@st3iny st3iny st3iny approved these changes

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: caldav Related to CalDAV internals feature: dav
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @st3iny @miaulalala