Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add mimetype for eml and msg #41803

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix: add mimetype for eml and msg #41803

merged 1 commit into from
Nov 29, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Nov 28, 2023

For nextcloud/files_emailviewer#1

Summary

Add mimetype mapping for eml and msg files

TODO

  • CI
  • Backport 28

Checklist

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb requested review from st3iny, a team, ArtificialOwl, icewind1991 and sorbaugh and removed request for a team November 28, 2023 21:38
@kesselb kesselb self-assigned this Nov 28, 2023
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, too

Uploaded MSG files are now detected with <d:getcontenttype>application/x-ole-storage</d:getcontenttype>

private function introduceEmlAndMsgFormatType() {
$updatedMimetypes = [
'eml' => 'message/rfc822',
'msg' => 'application/x-ole-storage',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yet I'm wondering if it should be application/vnd.ms-outlook

@ChristophWurst
Copy link
Member

/backport to stable28

@AndyScherzinger AndyScherzinger merged commit 16de85d into master Nov 29, 2023
52 checks passed
@AndyScherzinger AndyScherzinger deleted the register-eml-msg branch November 29, 2023 08:29
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants