Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve share logic for enforced password & expiry date #41885

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Nov 29, 2023

  • It's possible for the admin to enforce and expiry date after, some shares have been created. This commit makes possible to update the share with the new admin constraints.

  • This commit would users to modify enforced expiry to anything within range and less than the enforced limit in the pre-create dialog for public shares.

  • This commit fixes, unable to update share without updating password.

@AndyScherzinger
Copy link
Member

/backport to stable28

@AndyScherzinger
Copy link
Member

/backport to stable27

* It's possible for the admin to enforce and expiry date after, some
 shares have been created. This commit makes possible to update the
 share with the new admin constraints.

* This commit would users to modify enforced expiry to anything within
 range and less than the enforced limit in the pre-create dialog for public
 shares.

* This commit fixes, unable to update share without updating password.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@AndyScherzinger AndyScherzinger force-pushed the fix-enforced-options-share branch from 3581d36 to 9d86a04 Compare November 30, 2023 10:58
@AndyScherzinger
Copy link
Member

/compile /

@nfebe
Copy link
Contributor Author

nfebe commented Nov 30, 2023

/backport to stable28

@nfebe
Copy link
Contributor Author

nfebe commented Nov 30, 2023

/backport to stable27

@nfebe
Copy link
Contributor Author

nfebe commented Nov 30, 2023

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe
Copy link
Contributor Author

nfebe commented Nov 30, 2023

Cypress errors in user management unrelated.

@nfebe nfebe merged commit 5a4ac4a into master Nov 30, 2023
40 of 42 checks passed
@nfebe nfebe deleted the fix-enforced-options-share branch November 30, 2023 20:45
@AndyScherzinger AndyScherzinger added this to the Nextcloud 29 milestone Nov 30, 2023
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants