Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): add visible label to webdav URL in settings #41916

Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 29, 2023

Before After
image image

Checklist

Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the NcTextField suggestion

@ShGKme ShGKme force-pushed the fix/41835/files--add-visible-label-to-webdav-settings branch from a2cba58 to c6347a2 Compare November 29, 2023 23:39
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 29, 2023

Rebased onto master to resolve conflict

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/41835/files--add-visible-label-to-webdav-settings branch from c6347a2 to 15f9ec1 Compare December 1, 2023 19:57
@ShGKme ShGKme enabled auto-merge December 1, 2023 19:57
@ShGKme ShGKme merged commit 2091b5a into master Dec 1, 2023
42 checks passed
@ShGKme ShGKme deleted the fix/41835/files--add-visible-label-to-webdav-settings branch December 1, 2023 20:10
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 8, 2024

/backport 909d8f2 to stable28

@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants