-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable28] Synchronize operation on live photo files #41921
Conversation
Signed-off-by: Louis Chemineau <louis@chmn.me>
$this->handleDeletion($event, $peerFile); | ||
} elseif ($event instanceof CacheEntryRemovedEvent) { | ||
$peerFile->delete(); | ||
} elseif ($event instanceof BeforeNodeRestoredEvent) { |
Check failure
Code scanning / Psalm
RedundantCondition
} | ||
|
||
if ($event instanceof BeforeNodeRenamedEvent) { | ||
$this->handleMove($event, $peerFile); |
Check notice
Code scanning / Psalm
ArgumentTypeCoercion
if ($event instanceof BeforeNodeRenamedEvent) { | ||
$this->handleMove($event, $peerFile); | ||
} elseif ($event instanceof BeforeNodeDeletedEvent) { | ||
$this->handleDeletion($event, $peerFile); |
Check notice
Code scanning / Psalm
ArgumentTypeCoercion
} elseif ($event instanceof CacheEntryRemovedEvent) { | ||
$peerFile->delete(); | ||
} elseif ($event instanceof BeforeNodeRestoredEvent) { | ||
$this->handleRestore($event, $peerFile); |
Check notice
Code scanning / Psalm
ArgumentTypeCoercion
$event->abortOperation(new NotPermittedException("Cannot restore the video part of a live photo")); | ||
} | ||
} else { | ||
$user = $this->userSession->getUser(); |
Check notice
Code scanning / Psalm
PossiblyNullReference
766e45e
to
86d88f6
Compare
CI failure unrelated |
Backport of #41765 and #41924