Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] Handle close GlobalSearchModal gracefully #41792 #41930

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[stable28] Handle close GlobalSearchModal gracefully #41792 #41930

merged 1 commit into from
Nov 30, 2023

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Nov 30, 2023

Manual backport #41792

@nfebe nfebe added enhancement 4. to release Ready to be released and/or waiting for tests to finish feature: search labels Nov 30, 2023
@AndyScherzinger AndyScherzinger mentioned this pull request Nov 30, 2023
Merged
3 tasks
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Nov 30, 2023
@AndyScherzinger
Copy link
Member

/compile amend /

@nfebe @nextcloud-command
Handle close GlobalSearchModal gracefully
daafc73 
The current close infrastructure modifies a prop which has
 no real effect aside bugs.

In addition, calling the `NcModal.close()` as the primary way to
 close the search modal instead of using the states defined in `GlobalSearch` view
 causing re-open bugs (Modal cannot open, needs to click twice, and other weird stuff).

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe nfebe merged commit eeaf2a0 into stable28 Nov 30, 2023
41 of 42 checks passed
@nfebe nfebe deleted the 41792-manual-backport branch November 30, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: search
Projects
📁 Files team
Archived in project
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
2 participants
@nfebe @AndyScherzinger